refactor: Move storefrontapp occ config to 'private.providers.ts'; centralize common configs of b2b and b2c in one file; rename b2b and b2c files from '.module.ts' to '.providers.ts'" by Platonn · Pull Request #21181 · SAP/spartacus

Platonn · 2026-02-20T18:26:02Z

This reverts commit 70bc432.

What:

We're moving the OCC backend (and Media backend) configuration in storefrontapp from app.module.ts to spartacus-configuration.module.ts - to mimic better the fresh apps which have this config in their spartacus-configuration.module.ts.
And we extracting repeated config from spartacus-b2b-... and spartacus-b2c-configuration.module.ts to one spartacus-configuration.module.ts and moving the differing parts to renamed b2b and b2c ... .providers.ts files.

Why:

In https://jira.tools.sap/browse/CXSPA-11890 we've modernized storefrontapp to look more like a fresh app - i.e. we moved around configs between app.module, spartacus-storefront.module, spartacus-b2b-storefront.module, spartacus-b2c-storefront.module

But it turned our it broke our ec-automate-pipelines scripts, which caused deployment scripts to fail. So we quickly reverted those modernizations of storefrontapp in https://jira.tools.sap/browse/CXSPA-12046 (#21120) , to unblock the testing of the Feb2026 release, with the help of necessary deployment scripts

But now, after we're done with Feb2026 release, we'd like to bring back the modernization of the storefrontapp, and then we'll adjust the ec-automate-pipelines script.

Conflicts resolved with recent changes in develop
While applying a revert I resolved 2 conflicts with changes that were added in the meantime on develop:

backend.media config has been added to app.module.ts in feat: add mediaApiPrefix env var and backend.media.prefix config #21096 -> so I've moved it to private.providers.ts (near backend.occ` config
pwa.enable config has been disabled in github.com/chore: disable service worker in storefrontapp #21116 -> so I also keep it disabled

Notes for adjusting ec-automate-pipelines: (generated with Opus 4.5 and human-edited)

OLD Expectations of ec-automate-pipelines:

OCC BaseUrl Configuration

File: projects/storefrontapp/src/app/app.module.ts
Line pattern: baseUrl: environment.occBaseUrl

B2B Configuration

File: spartacus-b2b-configuration.module.ts (NgModule with @NgModule({ providers: [...] }))
Structure: Has providers: [ array inside NgModule decorator
PWA config: Located IN this file

B2C Configuration

File: spartacus-b2c-configuration.module.ts (NgModule)
PWA config: Located IN this file

PWA Configuration Location

B2B: In spartacus-b2b-configuration.module.ts
B2C: In spartacus-b2c-configuration.module.ts
PWA config enabled

NEW Expectations of ec-automate-pipelines should be:

OCC BaseUrl Configuration ⚠️ MOVED

New File: projects/storefrontapp/src/app/private/private.providers.ts
Old File: ~~app.module.ts~~ (no longer contains OCC config)
Line pattern: Same - baseUrl: environment.occBaseUrl

B2B Configuration ⚠️ RENAMED & RESTRUCTURED

New File: spartacus-b2b-configuration.providers.ts
Old File: ~~spartacus-b2b-configuration.module.ts~~ (deleted)
Structure: Uses makeEnvironmentProviders([...]) instead of NgModule
PWA config: NOT in this file anymore

B2C Configuration ⚠️ RENAMED & RESTRUCTURED

New File: spartacus-b2c-configuration.providers.ts (standalone providers function)
Old File: ~~spartacus-b2c-configuration.module.ts~~ (deleted)
PWA config: NOT in this file anymore

PWA Configuration Location ⚠️ CENTRALIZED

New Location: spartacus-configuration.module.ts (single location)
Old Location: ~~B2B and B2C modules separately~~ (removed)
PWA config IS ALREADY DISABLED (no need to disable it with ec-automate-pipelines)!

fixes https://jira.tools.sap/browse/CXSPA-12047

…nd restore b2b- and b2c-configuration.module.ts (#21120)" This reverts commit 70bc432.

…-12047

github-actions · 2026-02-20T18:33:08Z

🚨 PR Title Validation Failed 🚨

Your pull request title does not follow the required format. Please update it to match the expected pattern:

Expected format:
<type>: <subject>

Allowed Types

docs: Changes to documentation only
feat: New feature work
fix: Bug fixes
perf: Code improvements for performance
refactor: Code changes that are not bug fixes or features
style: Code style changes (e.g., whitespace, formatting)
test: Adding or updating tests
chore: Build, CI, scripts, configs, etc.

Example of a valid PR title

✅ feat: Add user authentication
✅ fix: Resolve checkout bug
✅ docs: Update API documentation

❌ Merge is blocked until the PR title is corrected.

github-actions · 2026-02-20T18:35:31Z

🚨 PR Title Validation Failed 🚨

Your pull request title does not follow the required format. Please update it to match the expected pattern:

Expected format:
<type>: <subject>

Allowed Types

docs: Changes to documentation only
feat: New feature work
fix: Bug fixes
perf: Code improvements for performance
refactor: Code changes that are not bug fixes or features
style: Code style changes (e.g., whitespace, formatting)
test: Adding or updating tests
chore: Build, CI, scripts, configs, etc.

Example of a valid PR title

✅ feat: Add user authentication
✅ fix: Resolve checkout bug
✅ docs: Update API documentation

❌ Merge is blocked until the PR title is corrected.

github-actions · 2026-02-20T18:48:55Z

🚨 PR Title Validation Failed 🚨

Your pull request title does not follow the required format. Please update it to match the expected pattern:

Expected format:
<type>: <subject>

Allowed Types

docs: Changes to documentation only
feat: New feature work
fix: Bug fixes
perf: Code improvements for performance
refactor: Code changes that are not bug fixes or features
style: Code style changes (e.g., whitespace, formatting)
test: Adding or updating tests
chore: Build, CI, scripts, configs, etc.

Example of a valid PR title

✅ feat: Add user authentication
✅ fix: Resolve checkout bug
✅ docs: Update API documentation

❌ Merge is blocked until the PR title is corrected.

pawelfras

Only now I realised that we have ci-scripts/update-ccv2.sh file that also refers to modules with configurations. Let's double-check (ideally with one of release masters) if the script is still in use and provide the following adjustments, if needed:

Change APP_MODULE_PATH to projects/storefrontapp/src/app/private/private.providers.ts
Update B2B_CONFIG_PATH to projects/storefrontapp/src/app/spartacus/spartacus-b2b-configuration.providers.ts
Update B2C_CONFIG_PATH to projects/storefrontapp/src/app/spartacus/spartacus-b2c-configuration.providers.ts
Adjust PWA config handling logic (now centralized in spartacus-configuration.module.ts)

pawelfras

LGTM. As discussed, let's inform other teams, so they can adjust CCv2 deployment scripts accordingly.

cypress · 2026-03-09T14:39:43Z

spartacus Run #52207

Run Properties: Passed #52207 • 6e05c3ff86 ℹ️: Merge 92c3979494e461a458464ee4e43f2a1642518d17 into 17f76f66a73d2aba5929b3616960...

Project	`spartacus`
Branch Review	`feature/CXSPA-12047`
Run status	`Passed #52207`
Run duration	`03m 20s`
Commit	`6e05c3ff86 ℹ️: Merge 92c3979494e461a458464ee4e43f2a1642518d17 into 17f76f66a73d2aba5929b3616960...`
Committer	`Krzysztof Platis`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`3`
Pending	`0`
Skipped	`0`
Passing	`101`
View all changes introduced in this branch ↗︎

Revert "fix: move back storefrontapp occ config to 'app.module.ts', a…

eea385b

…nd restore b2b- and b2c-configuration.module.ts (#21120)" This reverts commit 70bc432.

Platonn requested a review from a team as a code owner February 20, 2026 18:26

Merge branch 'develop' of github.com:SAP/spartacus into feature/CXSPA…

c6283f5

…-12047

github-actions bot marked this pull request as draft February 20, 2026 18:29

pawelfras reviewed Feb 23, 2026

View reviewed changes

Merge branch 'develop' into feature/CXSPA-12047

16aeff7

SAP deleted a comment from github-actions bot Mar 5, 2026

fix: update paths and configurations in update-ccv2.sh script

f4552a8

pawelfras approved these changes Mar 9, 2026

View reviewed changes

Merge branch 'develop' into feature/CXSPA-12047

912cc26

Platonn marked this pull request as ready for review March 9, 2026 14:13

Merge branch 'develop' into feature/CXSPA-12047

e8ecae2

github-actions bot marked this pull request as draft March 10, 2026 14:01

Merge branch 'develop' into feature/CXSPA-12047

92c3979

Platonn marked this pull request as ready for review March 11, 2026 09:08

Platonn merged commit 25312b2 into develop Mar 11, 2026
38 checks passed

Platonn deleted the feature/CXSPA-12047 branch March 11, 2026 09:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Move storefrontapp occ config to 'private.providers.ts'; centralize common configs of b2b and b2c in one file; rename b2b and b2c files from '.module.ts' to '.providers.ts'"#21181

refactor: Move storefrontapp occ config to 'private.providers.ts'; centralize common configs of b2b and b2c in one file; rename b2b and b2c files from '.module.ts' to '.providers.ts'"#21181
Platonn merged 7 commits intodevelopfrom
feature/CXSPA-12047

Platonn commented Feb 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

pawelfras left a comment

Uh oh!

pawelfras left a comment

Uh oh!

cypress bot commented Mar 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Platonn commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 20, 2026

🚨 PR Title Validation Failed 🚨

Allowed Types

Example of a valid PR title

Uh oh!

github-actions bot commented Feb 20, 2026

🚨 PR Title Validation Failed 🚨

Allowed Types

Example of a valid PR title

Uh oh!

github-actions bot commented Feb 20, 2026

🚨 PR Title Validation Failed 🚨

Allowed Types

Example of a valid PR title

Uh oh!

pawelfras left a comment

Choose a reason for hiding this comment

Uh oh!

pawelfras left a comment

Choose a reason for hiding this comment

Uh oh!

cypress bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

spartacus Run #52207

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Platonn commented Feb 20, 2026 •

edited

Loading

cypress bot commented Mar 9, 2026 •

edited

Loading