Skip to content

feat: add mediaApiPrefix env var and backend.media.prefix config #21096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
uroslates wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: add mediaApiPrefix env var and backend.media.prefix config #21096

uroslates wants to merge 6 commits into from

Conversation

@uroslates
Copy link
Contributor

@uroslates uroslates commented Jan 30, 2026 •
edited
Loading

Closes: https://jira.tools.sap/browse/CXSPA-12005

Adding

  • new Spartacus backend.media.prefix (hidden behind enableMediaPrefix feature flag) - similar to backend.occ.prefix. The new config is used when constructing the media baseUrl (added to the configured host as suffix === uri).
  • new Spartacus environment(-prod).ts file via mediaBaseUrl and mediaApiPrefix used for configuring backend.media.baseUrl and backend.media.prefix respectively.

@uroslates uroslates requested a review from a team as a code owner January 30, 2026 08:18
@github-actions github-actions bot marked this pull request as draft January 30, 2026 08:18
@uroslates uroslates marked this pull request as ready for review January 30, 2026 17:38
@cypress
Copy link

cypress bot commented Jan 30, 2026 •
edited
Loading

spartacus    Run #51561

Run Properties:  status check passed Passed #51561  •  git commit 6292ed3c38 ℹ️: Merge d6a10bf22bb9160c8f13f6f441052a862eb197ce into a342f7ba450013d27ea9106fe38f...
Project spartacus
Branch Review feature/CXSPA-12006-media-prefix
Run status status check passed Passed #51561
Run duration 11m 21s
Commit git commit 6292ed3c38 ℹ️: Merge d6a10bf22bb9160c8f13f6f441052a862eb197ce into a342f7ba450013d27ea9106fe38f...
Committer Uros Lates
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 101
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@StanislavSukhanov StanislavSukhanov self-requested a review February 3, 2026 10:04
StanislavSukhanov
StanislavSukhanov reviewed Feb 3, 2026
View reviewed changes
Copy link
Contributor

@StanislavSukhanov StanislavSukhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @uroslates great job! Left some comments/suggestions

StanislavSukhanov
StanislavSukhanov requested changes Feb 3, 2026
View reviewed changes
@github-actions github-actions bot marked this pull request as draft February 3, 2026 11:38
@uroslates uroslates marked this pull request as ready for review February 3, 2026 11:38
StanislavSukhanov
StanislavSukhanov requested changes Feb 3, 2026
View reviewed changes
@github-actions github-actions bot marked this pull request as draft February 3, 2026 14:46
@uroslates uroslates marked this pull request as ready for review February 3, 2026 14:49
@github-actions github-actions bot marked this pull request as draft February 3, 2026 15:24
@uroslates uroslates marked this pull request as ready for review February 3, 2026 15:25
StanislavSukhanov
StanislavSukhanov approved these changes Feb 4, 2026
View reviewed changes
Copy link
Contributor

@StanislavSukhanov StanislavSukhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanislavSukhanov StanislavSukhanov StanislavSukhanov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uroslates @StanislavSukhanov