Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CXSPA-8270 fix random failing unit tests #19417

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

CXSPA-8270 fix random failing unit tests #19417

wants to merge 5 commits into from
+89 −90

Conversation

Uli-Tiger
Copy link
Contributor

  • avoid overriding methods in global objects, such as window. Instead inject mocks. Make sure those mocks have a well defined state after beforeEach() to ensure test isolation.

@Uli-Tiger
CXSPA-8270 fix random failing unit tests
808b2e4 
* avoid overriding methods in global objects, such as window. Instead inject mocks. Make sure those mocks have a well defined state after beforeEach() to ensure test isolation.
@Uli-Tiger Uli-Tiger requested review from a team as code owners October 18, 2024 14:50
@github-actions github-actions bot marked this pull request as draft October 18, 2024 14:51
@Uli-Tiger Uli-Tiger marked this pull request as ready for review October 18, 2024 15:33
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft October 18, 2024 15:34
@Uli-Tiger Uli-Tiger marked this pull request as ready for review October 18, 2024 15:52
@github-actions github-actions bot marked this pull request as draft October 18, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Larisa-Staroverova Larisa-Staroverova Awaiting requested review from Larisa-Staroverova

@ChristophHi ChristophHi Awaiting requested review from ChristophHi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Uli-Tiger