Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (CXSPA-8668) - Image zoom legacy media component styles #19414

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix: (CXSPA-8668) - Image zoom legacy media component styles #19414

wants to merge 5 commits into from
+3 −1

Conversation

Pio-Bar
Copy link
Contributor

@Pio-Bar Pio-Bar commented Oct 18, 2024 •
edited
Loading

Closes: CXSPA-8668

Let's use a more specific selector to make sure the legacy media component remains unchanged.
This way both versions behave predictably.

@Pio-Bar Pio-Bar requested a review from a team as a code owner October 18, 2024 12:03
@github-actions github-actions bot marked this pull request as draft October 18, 2024 12:03
@Pio-Bar Pio-Bar marked this pull request as ready for review October 18, 2024 12:06
@cypress Cypress
Copy link

cypress bot commented Oct 18, 2024

spartacus    Run #45395

Run Properties:  status check passed Passed #45395  •  git commit ed9509cb7c ℹ️: Merge f7a90d7d3a710d436838d65443f20637a75e23ed into 1499ec54a175d53f1b89b5ef28d1...
Project spartacus
Run status status check passed Passed #45395
Run duration 03m 44s
Commit git commit ed9509cb7c ℹ️: Merge f7a90d7d3a710d436838d65443f20637a75e23ed into 1499ec54a175d53f1b89b5ef28d1...
Committer PioBar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

rmch91
rmch91 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@rmch91 rmch91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmch91 rmch91 rmch91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pio-Bar @rmch91