fix: (CXSPA-8156) add landmark for checkout delivery address section #19405
+101
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||
| Project |
spartacus
|
| Run status |
|
| Run duration | 03m 35s |
| Commit |
|
| Committer | Stanislav Sukhanov |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
StanislavSukhanov
force-pushed
the
feature/CXSPA-8156-associate-add-address-button-with-section-title
branch
from
42b599d
to
020d282
Compare
Pio-Bar
previously approved these changes
Oct 17, 2024
| <h2 class="cx-checkout-title d-none d-lg-block d-xl-block"> | ||
| {{ 'checkoutAddress.shippingAddress' | cxTranslate }} | ||
| </h2> | ||
| <section [attr.aria-label]="'checkoutAddress.shippingAddress' | cxTranslate"> |
There was a problem hiding this comment.
Unfortunately, I think changing the structure here would be breaking.
There was a problem hiding this comment.
Hi @Pio-Bar! Thanks for your comment 👍 . Fixed
* add a landmark for checkout delivery address component to get a 'new address button' associated with an appropriate content. * closes https://jira.tools.sap/browse/CXSPA-8156
* add a landmark for checkout delivery address component to get a 'new address button' associated with an appropriate content. * add an aria-describedby attribute to 'new address button' to get it narrated in Voice Over. * closes https://jira.tools.sap/browse/CXSPA-8156
* add a landmark for checkout delivery address component to get a 'new address button' associated with an appropriate content. * closes https://jira.tools.sap/browse/CXSPA-8156
* add feature toggles; * closes https://jira.tools.sap/browse/CXSPA-8156
StanislavSukhanov
force-pushed
the
feature/CXSPA-8156-associate-add-address-button-with-section-title
branch
from
020d282
to
cd9e468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a landmark for checkout delivery address component to get a 'new address button' associated with an appropriate content.
closes https://jira.tools.sap/browse/CXSPA-8156