Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add opf sub-libs to schematics #19387

Merged
merged 10 commits into from
Oct 18, 2024
Merged

feat: add opf sub-libs to schematics #19387

merged 10 commits into from
Oct 18, 2024

Conversation

FollowTheFlo
Copy link
Contributor

@FollowTheFlo FollowTheFlo commented Oct 10, 2024

Tested schematics with the 2 syntax: lowerCamel and hyphen separated

ng add @spartacus/schematics@latest --base-url https://api.cp96avkh5f-integrati2-s1-public.model-t.cc.commerce.ondemand.com/ --base-site electronics-spa --commerceCloudPublicKey=ab4RhYGZ+w5B0SALMPOPlepWk/kmDQjTy2FU5hrQoFg= --opfBaseUrl=https://opf-iss-d0.opf.commerce.stage.context.cloud.sap/commerce-cloud-adapter/storefront

ng add @spartacus/schematics@latest --base-url https://api.cp96avkh5f-integrati2-s1-public.model-t.cc.commerce.ondemand.com/ --base-site electronics-spa --commerce-cloud-public-key ab4RhYGZ+w5B0SALMPOPlepWk/kmDQjTy2FU5hrQoFg= --opf-base-url https://opf-iss-d0.opf.commerce.stage.context.cloud.sap/commerce-cloud-adapter/storefront

Tested opf schematic directly ng add @spartacus/opf@latest with the prompt
Tested run-time to make sure api calls have the correct url.

@FollowTheFlo FollowTheFlo requested a review from a team as a code owner October 10, 2024 18:34
@Matejk00
Copy link
Contributor

Matejk00 commented Oct 17, 2024

The installation script add_opf function should be adjusted as well, to use a new command/flag:

image

@Matejk00 Matejk00 self-requested a review October 18, 2024 05:34
Copy link
Contributor

@Matejk00 Matejk00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@FollowTheFlo FollowTheFlo merged commit 7e0070c into epic/opf Oct 18, 2024
10 checks passed
@FollowTheFlo FollowTheFlo deleted the feature/CXSPA-8629 branch October 18, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants