Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC: Upgrade to Angular 18 #19384

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

pawelfras
Copy link
Contributor

TBD

- "@angular-eslint/eslint-plugin": "17.0.1",
- "@angular-eslint/eslint-plugin-template": "17.0.1",
- "@angular-eslint/template-parser": "17.0.1",
- "@nx/angular" bumped from `17.3.2` to `20.0.0`
- "@nx/devkit" bumped from `17.3.2` to `20.0.0`
- "@nx/eslint-plugin" bumped from `17.3.2` to `20.0.0`
- "@nx/jest" bumped from `17.3.2` to `20.0.0`
- "@nx/workspace" bumped from `17.3.2` to `20.0.0`
- "@types/jest" bumped from `29.4.0` to `29.5.13`
- "jest" bumped from `29.0.0` to `29.7.0`
- "jest-preset-angular" bumped from `13.1.6` to `14.1.1`
- "nx" bumped from `17.3.2` to `20.0.0`,
- `"useInferencePlugins": false` added to `nx.json`
- `/.nx/workspace-data` added to `.gitignore` and `.prettierignore`
 - "@angular/animations" bumped from `^17.0.5` to `18.2.7`
 - "@angular/common" bumped from `^17.0.5` to `18.2.7`
 - "@angular/compiler" bumped from `^17.0.5` to `18.2.7`
 - "@angular/core" bumped from `^17.0.5` to `18.2.7`
 - "@angular/forms" bumped from `^17.0.5` to `18.2.7`
 - "@angular/platform-browser" bumped from `^17.0.5` to `18.2.7`
 - "@angular/platform-browser-dynamic" bumped from `^17.0.5` to `18.2.7`
 - "@angular/platform-server" bumped from `^17.0.5` to `18.2.7`
 - "@angular/router" bumped from `^17.0.5` to `18.2.7`
 - "@angular/service-worker" bumped from `^17.0.5` to `18.2.7`
 - "@angular/compiler-cli" bumped from `^17.0.5` to `18.2.7`
 - "@angular/language-service" bumped from `^17.0.5` to `18.2.7`
 - replaced deprecated HTTP related modules with provider functions
 - fixed issues after replacement in some tests (redundant code)
 - ran `npm run prettier:fix` to format migrated code
 - "@ngrx/effects" bumped from `17.0.1` to `18.1.0`
 - "@ngrx/router-store" bumped from `17.0.1` to `18.1.0`
 - "@ngrx/store" bumped from `17.0.1` to `18.1.0`
 - "@ngrx/store-devtools" bumped from `17.0.1` to `18.1.0`
 - "@ngrx/operators" introduced
 - `TypedAction` removed in favour of `Action`
 - "@angular/pwa" bumped from `17.0.5` to `18.2.7`
 - "@angular/ssr" bumped from `17.0.5` to `18.2.7`
 - "@ng-select/ng-select" bumped from `12.0.4` to `13.9.0`
 - "ngx-infinite-scroll" bumped from `17.0.0` to `18.0.0`
 - "zone.js" bumped from `0.14.2` to `0.14.10`
 - "@angular-builders/custom-webpack" bumped from `15.0.0` to `18.0.0`
 - "@angular-devkit/build-angular" bumped from `17.0.5` to `18.2.7`
 - "@angular-devkit/core" bumped from `17.0.5` to `18.2.7`
 - "@angular-devkit/schematics" bumped from `17.0.5` to `18.2.7`
 - "@angular-eslint/builder" bumped from `17.1.0` to `18.3.1`
 - "@angular-eslint/eslint-plugin" bumped from `17.3.0` to `18.3.1`
 - "@angular-eslint/eslint-plugin-template" bumped from `17.3.0` to `18.3.1`
 - "@angular-eslint/schematics" bumped from `17.1.0` to `18.3.1`
 - "@angular-eslint/template-parser" bumped from `17.3.0` to `18.3.1`
 - "@angular-eslint/utils" bumped from `17.1.0` to `18.3.1`
 - "@angular/cli" bumped from `17.0.5` to `18.2.7`
 - "@schematics/angular" bumped from `17.0.5` to `18.2.7`
 - "@typescript-eslint/eslint-plugin" bumped from `6.13.1` to `8.8.1`
 - "@typescript-eslint/parser" bumped from `6.13.1` to `8.8.1`
 - "@typescript-eslint/utils" bumped from `6.13.1` to `8.8.1`
 - "ng-packagr" bumped from `17.0.2` to `18.2.1`
@pawelfras pawelfras requested review from a team as code owners October 10, 2024 13:13
- replaced `Observable<boolean | UrlTree> with combined `Observable<GuardResult>` from @angular/router
  for more, see: angular/angular#45023
- add `node` to "types" in all `tsconfig.schematics.json` to support node API
- remove redundant `dist` and `assets` property from nested ng-package.json in CDP and OMF
  for more, see: https://github.com/ng-packagr/ng-packagr/pull/2754/files
@pawelfras pawelfras force-pushed the feature/CXSPA-8529-angular-18-upgrade branch from c6b88bc to da2e728 Compare October 11, 2024 13:53
- add support for `RedirectCommand` type in guard tests
- adjust `order-return-requrest-list.component.spec.ts` to look for `input[aria-controls="order-return-table"]` instead of `div[aria-controls="order-return-table"]` due to changes in `ng-select`
for more, see: ng-select/ng-select#2428
- remove `recommended` property from eslint rules
- add `fix-jsdom-environment.ts` containing fix for missing support of structuredClone in `jest-environment-jsdom`
for more, see: jsdom/jsdom#3363 (comment)
- `convertAnnotatedSourceToFailureCase` is now imported from `@angular-eslint/test-utils`(new dependency) instead from `@angular-eslint/utils`
- include TS files in `tsconfig.spec.json`
- adjust directive to look for `input[aria-controls="order-return-table"]` instead of `div[aria-controls="order-return-table"]` due to changes in `ng-select` library
    for more, see: ng-select/ng-select#2428
- added new `@stylistic/eslint-plugin-ts` due to moving some there som config from `@typescript-eslint/eslint-plugin`:
  - `quotes`
  - `member-delimiter-style`
  - `semi`
  - type-annotation-spacing`
  for more, see e.g.: https://typescript-eslint.io/rules/member-delimiter-style/
- removed redundant rules from `legacy-ng-cli-compat` files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant