GHAS. Fix Prototype-polluting assignment. Core #19376
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/SAP/spartacus/security/code-scanning/21
To fix the prototype pollution issue, we need to ensure that
productCode
cannot be set to special properties like__proto__
,constructor
, orprototype
. This can be achieved by validating theproductCode
before using it as a key in theproducts
object.Steps to fix:
productCode
is one of the special properties.productCode
is invalid, handle the error appropriately (e.g., by returning an error response or throwing an exception).Suggested fixes powered by Copilot Autofix. Review carefully before merging.