GHAS. Translations. Fix Incomplete string escaping or encoding #19375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
giancorderoortiz
changed the title
spartacus
|
||||||||||||||||||||||||||
| Project |
spartacus
|
| Run status |
|
| Run duration | 19m 18s |
| Commit |
|
| Committer | Giancarlo Cordero Ortiz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/SAP/spartacus/security/code-scanning/55
To fix the problem, we need to ensure that backslashes are properly escaped in the
stringifyfunction. This can be done by adding a step to replace backslashes with double backslashes before handling other characters. Specifically, we should update thereplacemethod on line 151 to first escape backslashes and then handle double quotes.stringifyfunction to include backslash escaping.replacemethod to handle backslashes before replacing double quotes.scripts/i18n/convert-translations-json-2-ts.tsfile.Suggested fixes powered by Copilot Autofix. Review carefully before merging.