Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (CXSPA-1028) - Missing close buttons title attributes #19329

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

Pio-Bar
Copy link
Contributor

@Pio-Bar Pio-Bar commented Oct 3, 2024

Ticket: CXSPA-1028

I've looked through all buttons like this on the app. We've missed these two cases previously!

@Pio-Bar Pio-Bar requested a review from a team as a code owner October 3, 2024 10:41
@github-actions github-actions bot marked this pull request as draft October 3, 2024 10:41
@Pio-Bar Pio-Bar marked this pull request as ready for review October 3, 2024 10:55
Copy link

cypress bot commented Oct 3, 2024

spartacus    Run #45361

Run Properties:  status check passed Passed #45361  •  git commit bde1abe9d5 ℹ️: Merge d097bf6a57d6425eb755b9a2866065174eed1a15 into 0393225f869142c5b203be49f239...
Project spartacus
Run status status check passed Passed #45361
Run duration 04m 04s
Commit git commit bde1abe9d5 ℹ️: Merge d097bf6a57d6425eb755b9a2866065174eed1a15 into 0393225f869142c5b203be49f239...
Committer PioBar
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125

@github-actions github-actions bot marked this pull request as draft October 17, 2024 07:48
@Pio-Bar Pio-Bar marked this pull request as ready for review October 17, 2024 10:29
@Pio-Bar Pio-Bar merged commit 35a1751 into develop Oct 17, 2024
28 checks passed
@Pio-Bar Pio-Bar deleted the feature/CXSPA-1028 branch October 17, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants