Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improve rendering performance for large configuration models [CXSPA-7477] #19099

Merged

Conversation

Uli-Tiger
Copy link
Contributor

…models [CXSPA-7477] (#18997)"

This reverts commit e228991.

original PR #18997 was merged to early and had to be reverted, this restores it to be merged for 2409 release.

@Uli-Tiger Uli-Tiger requested review from a team as code owners August 1, 2024 16:18
@github-actions github-actions bot marked this pull request as draft August 1, 2024 16:18
@Uli-Tiger Uli-Tiger requested a review from Platonn August 1, 2024 16:18
@Uli-Tiger Uli-Tiger changed the title Reapply "perf: Improve rendering performance for large configuration … perf: Improve rendering performance for large configuration models [CXSPA-7477] Aug 1, 2024
@Uli-Tiger Uli-Tiger marked this pull request as ready for review August 1, 2024 16:22
Copy link

cypress bot commented Aug 1, 2024



Test summary

119 0 2 0Flakiness 3


Run details

Project spartacus
Status Passed
Commit d4e573f ℹ️
Started Aug 5, 2024 4:48 AM
Ended Aug 5, 2024 4:51 AM
Duration 03:49 💡
OS Linux Ubuntu -
Browser Electron 118

View run in Cypress Cloud ➡️


Flakiness

cypress/e2e/ssr/pages.core-e2e.cy.ts Flakiness
1 SSR > should render homepage
2 SSR > should render PLP
3 SSR > should render PDP

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link
Contributor

@Larisa-Staroverova Larisa-Staroverova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA review:

  1. B2C with CPS engine:
  • CPQ_LAPTOP,
  • CONF_CAMERA_SL,
  • CONF_COFFEEMACH_V2.
  1. B2B with CPQ engine:
  • CONF_CAMERA_BUNDLE,
  • CONF_COFFEEMACHINE_3000.

Cypress tests:

  • B2B quote,
  • B2B with CPQ engine
  • B2C with mock.

Testing was successful.

@github-actions github-actions bot marked this pull request as draft August 5, 2024 04:32
@Larisa-Staroverova Larisa-Staroverova marked this pull request as ready for review August 5, 2024 04:38
@Larisa-Staroverova Larisa-Staroverova merged commit e24eee4 into develop Aug 6, 2024
28 checks passed
@Larisa-Staroverova Larisa-Staroverova deleted the feature/CXSPA-7477_restore_after_release branch August 6, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants