Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CXMC-13000: mcs customer login with CDC hosted page #19080

Merged
merged 38 commits into from
Aug 15, 2024
Merged

CXMC-13000: mcs customer login with CDC hosted page #19080

merged 38 commits into from
Aug 15, 2024

Conversation

i53577
Copy link
Contributor

@i53577 i53577 commented Jul 26, 2024

No description provided.

i53577 and others added 25 commits July 22, 2024 17:24
@i53577
CXMC-13000: draft
950337a
@i53577
draft
04ce9d5
@i53577
CXMC-13000: add spinner and auto reroute
87dbcb8
@github-actions
Add license header
bbf585e
@i53577
CXMC-13000: revert unused change
099782c
@i53577
Merge branch 'feature/CXMC-13000' of github.com:SAP/spartacus into fe…
81c4c07 
…ature/CXMC-13000
@i53577
CXMC-13000: revert unused change
e291698
@i53577
CXMC-13000: restrict cdc login page to anonymous user
db06459
@i53577
CXMC-13000: draft
d70e709
@i53577
CXMC-13000: draft
b252110
@i53577
CXMC-13000: add isRedirect to handle login
63bb211
@i53577
CXMC-13000: make authconfig configurable
fd63f72
@i53577
CXMC-13000: revert changes and create a new component
6c15d45
@i53577
CXMC-13000: remove unused set token logic
4f67b34
@i53577
CXMC-13000: add dependency
411f24e
@i53577
use test site host page
e51f930
@i53577
use initLoginFlow to start pkce
758b11d
@i53577
CXMC-13000: reuse existing logic
a89fe6d
@i53577
CXMC-13000: use new cms config
040c899
@i53577
CXMC-13000: remove unwanted change
f697d85
@i53577
CXMC-13000: remove unwanted change
634f2cb
@i53577
CXMC-13000:add e2e test with oidc login flow
81a3333
@i53577
CXMC-13000: change api key
7b9fbec
@i53577
CXMC-13000: draft
04b8001
@i53577
Merge branch 'develop' into feature/CXMC-13000
006ac77
@i53577 i53577 changed the base branch from develop to poc/cdc-oidc August 8, 2024 09:00
@i53577 i53577 changed the base branch from poc/cdc-oidc to develop August 8, 2024 09:02
@i53577 i53577 requested review from a team as code owners August 9, 2024 10:21
@github-actions github-actions bot marked this pull request as draft August 9, 2024 10:24
@i53577 i53577 changed the title CXMC-13000: draft CXMC-13000: mcs customer login with CDC hosted page Aug 9, 2024
@i53577 i53577 marked this pull request as ready for review August 9, 2024 13:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft August 9, 2024 14:02
@i53577 i53577 marked this pull request as ready for review August 12, 2024 08:48
@github-actions GitHub Actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

scarai-sap
scarai-sap reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@scarai-sap scarai-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments added

feature-libs/user/account/components/login-form-cdc/login-form-cdc.component.spec.ts Outdated Show resolved Hide resolved
feature-libs/user/account/components/login-form-cdc/login-form-cdc.component.ts Outdated Show resolved Hide resolved
feature-libs/user/account/components/login-form-cdc/login-form-cdc.component.ts Outdated Show resolved Hide resolved
feature-libs/user/account/components/login-form-cdc/login-form-cdc.component.spec.ts Outdated Show resolved Hide resolved
feature-libs/user/account/components/login-form-cdc/login-form-cdc.component.ts Outdated Show resolved Hide resolved
feature-libs/user/account/components/login-form-cdc/login-form-cdc.component.ts Outdated Show resolved Hide resolved
feature-libs/user/account/components/login-form-cdc/login-form-cdc.component.ts Outdated Show resolved Hide resolved
vinchen666
vinchen666 reviewed Aug 12, 2024
View reviewed changes
feature-libs/user/package.json
@@ -22,7 +22,8 @@
"test:schematics": "npm --prefix ../../projects/schematics/ run clean && npm run clean:schematics && ../../node_modules/.bin/jest --config ./jest.schematics.config.js"
},
"dependencies": {
"tslib": "^2.6.2"
"tslib": "^2.6.2",
"angular-oauth2-oidc": "^17.0.1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to introduce this lib, should be there already

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a ticket to track this https://jira.tools.sap/browse/CXSPA-8184

@github-actions github-actions bot marked this pull request as draft August 13, 2024 05:23
@i53577 i53577 changed the base branch from develop to feature/mcs-cdc-login August 15, 2024 02:19
@i53577 i53577 marked this pull request as ready for review August 15, 2024 02:19
@i53577 i53577 merged commit c188a9a into feature/mcs-cdc-login Aug 15, 2024
13 checks passed
@i53577 i53577 deleted the feature/CXMC-13000 branch August 15, 2024 02:19
vinchen666
vinchen666 reviewed Aug 26, 2024
View reviewed changes
feature-libs/user/account/components/login-form-oidc/login-form-oidc.module.ts
providers: [
provideDefaultConfig(<CmsConfig>{
cmsComponents: {
ReturningOIDCLoginComponent: {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this component will be used for both login and return, so the name ReturningOIDCLoginComponent is not accurate

vinchen666
vinchen666 reviewed Aug 26, 2024
View reviewed changes
projects/storefrontapp-e2e-cypress/cypress.config.ts
@@ -14,6 +14,7 @@ export default defineConfig({
runMode: 2,
},
videoUploadOnPasses: false,
chromeWebSecurity: false,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to set chromeWebSecurity to false, do we need to remove this line when go to production, if yes do we have a ticket to follow up?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's already in false in pipeline configuration as

spartacus/projects/storefrontapp-e2e-cypress/cypress.config.ci.ts

Line 16 in aebb574

chromeWebSecurity: false,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niehua niehua niehua left review comments

@scarai-sap scarai-sap scarai-sap left review comments

@vinchen666 vinchen666 vinchen666 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@i53577 @niehua @scarai-sap @vinchen666