Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop 6.2.x #17648

Merged
merged 13 commits into from
Jul 17, 2023
Merged

Develop 6.2.x #17648

merged 13 commits into from
Jul 17, 2023

Conversation

KeerthiSap
Copy link

No description provided.

i333055 and others added 13 commits June 21, 2023 15:09
@i333055
fix: add jira num for e2e tests (#17552)
88d56e6
@luoyifeng11
test: Fix the instability issue in ASM E2E tests, as well as the fail…
23e537e 
…ure issue in asm-cost-center.e2e (#17487)
@pawelfras
feat: CXSPA-3742 - SSR logging - addresing minor comments (#17538)
4464f61
@scarai-sap
feat: update text as UX suggested #17522 for 6.2 (#17565)
05cc70b
@luoyifeng11
test: fix ASM E2E test instability for 6.2 (#17569)
eebc403
@i53577
fix: Need to adapt to the width of mobile webpage on CustomerList (#1…
cfa7efd 
…7576)
@niehuayang
fix/CXSPA-3848: cherry-pick buf fixes from branch 6.1.x to branch 6.2…
f3d508b 
….x (#17579)
@ChristophHi
fix: configurator restart must remove UI state as well (#17581)
47346c7 
See https://jira.tools.sap/browse/CXSPA-3839
@pawelfras
chore: CXSPA-3794 - SSR contextual logging extensibility (#17578)
ed1e1a7
@Platonn
fix: 'this' is undefined in ProductEffects.productLoadEffect (#17594)
6d5b7ba 
Previous behavior: When `/products` endpoint returned a http error, the code broke in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L77), complaining that `this` is undefined.

Fix: Preserve the context of `this` which was lost in [this line](https://github.com/SAP/spartacus/blob/ed1e1a78c488b1e1214491ffa736612287f8cf70/projects/core/src/product/store/effects/product.effect.ts#L52)

The problem was revealed only after we implemented [CXSPA-2251](https://jira.tools.sap/browse/CXSPA-2251) where we referenced `this` by adding `this.logger` to the method `ProductEffects.productLoadEffect`

fixes https://jira.tools.sap/browse/CXSPA-3902
@anjana-bl
CDC-B2B- Bug (#17628)
c8de006
@RadhepS
Release 6.2.0
39b18c3
@kimhw0630 @hakwookim
Release 6.2.1 (#17640)
afa21b1 
Co-authored-by: Hakwoo Kim <[email protected]>
@KeerthiSap KeerthiSap requested a review from a team as a code owner July 17, 2023 05:22
@KeerthiSap KeerthiSap requested a review from a team July 17, 2023 05:22
@KeerthiSap KeerthiSap requested review from a team as code owners July 17, 2023 05:22
@KeerthiSap KeerthiSap merged commit 0f3f22c into update-6.2.x Jul 17, 2023
24 of 26 checks passed
@KeerthiSap KeerthiSap deleted the develop-6.2.x branch July 17, 2023 05:22
@KeerthiSap KeerthiSap restored the develop-6.2.x branch July 17, 2023 05:25
@KeerthiSap KeerthiSap temporarily deployed to dev July 17, 2023 05:25 — with GitHub Actions Inactive
@KeerthiSap KeerthiSap deleted the develop-6.2.x branch July 17, 2023 05:25
@KeerthiSap KeerthiSap restored the develop-6.2.x branch July 17, 2023 05:31
@KeerthiSap KeerthiSap temporarily deployed to dev July 17, 2023 05:31 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.