Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pre-fill delivery address for guest users #17607

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

kpawelczak
Copy link
Contributor

The checkout config has a new option "guestUseSavedAddress"

BREAKING CHANGE:

Checkout config has a new option; CheckoutConfigService is injected in a constructor of CheckoutDeliveryAddressComponent.

Closes: https://jira.tools.sap/browse/CXSPA-3591

@kpawelczak kpawelczak requested a review from a team as a code owner July 5, 2023 08:59
@github-actions github-actions bot marked this pull request as draft July 5, 2023 08:59
@kpawelczak kpawelczak marked this pull request as ready for review July 5, 2023 14:34
@cypress
Copy link

cypress bot commented Jul 5, 2023

4 flaky tests on run #40986 ↗︎

0 119 2 0 Flakiness 4

Details:

Merge 25a9b95 into 16fee09...
Project: spartacus Commit: eb086107eb ℹ️
Status: Passed Duration: 07:00 💡
Started: Jul 11, 2023 1:51 PM Ended: Jul 11, 2023 1:58 PM
Flakiness  regression/asm/asm.emulation.core-e2e.cy.ts • 1 flaky test • B2C

View Output Video

Test Artifacts
Assisted Service Module > Apparel Site > should fetch products in a category based on the emulated user's authentication Output Screenshots
Flakiness  ssr/pages.core-e2e.cy.ts • 3 flaky tests • SSR

View Output Video

Test Artifacts
SSR > should render homepage Output Screenshots
SSR > should render PLP Output Screenshots
SSR > should render PDP Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions github-actions bot marked this pull request as draft July 11, 2023 13:32
@kpawelczak kpawelczak marked this pull request as ready for review July 11, 2023 13:36
@kpawelczak kpawelczak merged commit 1cb1fb5 into develop-6.3.x Jul 11, 2023
22 checks passed
@kpawelczak kpawelczak deleted the feat/CXSPA-3591-pre-fill-address branch July 11, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants