New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable codeql. Based on pr 12402 #14926

Draft

giancorderoortiz wants to merge 24 commits into develop from feature/GH-14925_enable_codeql

Contributor

giancorderoortiz commented Feb 1, 2022

DO NOT MERGE.
SEC SCANNING ONLY


          Enable codeql. Based on pr 12402

c0dd681

giancorderoortiz requested a review from a team

February 1, 2022 16:47

giancorderoortiz temporarily deployed to dev

February 1, 2022 16:47

Inactive

cypress bot commented Feb 1, 2022 •

edited

Loading

Test summary

406 • 1 • 1 • 0 • 5

Run details


Project	spartacus
Status	Failed
Commit	`09be452` ℹ️
Started	Aug 5, 2022 6:33 PM
Ended	Aug 5, 2022 6:44 PM
Duration	11:00 💡
OS	Linux Ubuntu - 20.04
Browser	Electron 91

View run in Cypress Dashboard ➡️

Failures

	cypress/integration/accessibility/product-configurator-tabbing.core-e2e-spec.ts		1
1	Product Configuration > Product Config Tabbing > should allow to navigate with tab key

Flakiness

	regression/product_configurator/product-configurator-vc-interactive.core-e2e-spec.ts		1
1	Product Configuration > Group Handling > should check if group buttons are clickable
	ssr/pages.core-e2e-spec.ts		3
1	SSR > should render homepage
2	SSR > should render PLP
3	SSR > should render PDP
	regression/variants/apparel-cart-import-export.core-e2e-spec.ts		1
1	... > should import to saved cart

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard


          Merge branch 'develop' into feature/GH-14925_enable_codeql

a56ec33

giancorderoortiz temporarily deployed to dev

February 1, 2022 22:38

Inactive


          Merge branch 'develop' into feature/GH-14925_enable_codeql

efe6664

giancorderoortiz temporarily deployed to dev

February 2, 2022 18:51

Inactive


          Merge branch 'develop' into feature/GH-14925_enable_codeql

ad11af8

giancorderoortiz temporarily deployed to dev

February 18, 2022 21:51

Inactive


          Merge branch 'develop' into feature/GH-14925_enable_codeql

67d65d0

giancorderoortiz requested a review from a team as a code owner

March 3, 2022 12:32

giancorderoortiz temporarily deployed to dev

March 3, 2022 12:33

Inactive


          Merge branch 'develop' into feature/GH-14925_enable_codeql

06469a2

giancorderoortiz temporarily deployed to dev

March 7, 2022 15:44

Inactive


          Merge branch 'develop' into feature/GH-14925_enable_codeql

giancorderoortiz temporarily deployed to dev

March 9, 2022 17:40

Inactive


          Merge branch 'develop' into feature/GH-14925_enable_codeql

0b52907

giancorderoortiz temporarily deployed to dev

March 16, 2022 14:55

Inactive


          Merge branch 'develop' into feature/GH-14925_enable_codeql

2f92c34

giancorderoortiz temporarily deployed to dev

March 17, 2022 13:23

Inactive


          Merge branch 'develop' into feature/GH-14925_enable_codeql

e9b0867

giancorderoortiz temporarily deployed to dev

March 30, 2022 22:21

Inactive


          Merge branch 'develop' into feature/GH-14925_enable_codeql

23799e7

giancorderoortiz temporarily deployed to dev

April 3, 2022 21:48

Inactive


          Merge branch 'develop' into feature/GH-14925_enable_codeql

95a015e

giancorderoortiz temporarily deployed to dev

April 5, 2022 09:47

Inactive

giancorderoortiz added 3 commits

April 26, 2022 08:03


          Merge branch 'develop' into feature/GH-14925_enable_codeql

26a6bc8


          Merge branch 'develop' into feature/GH-14925_enable_codeql

ea75c5b


          Merge branch 'develop' into feature/GH-14925_enable_codeql

e2bd81f

giancorderoortiz added 2 commits

June 10, 2022 12:47


          Merge branch 'develop' into feature/GH-14925_enable_codeql

364832f


          Merge branch 'develop' into feature/GH-14925_enable_codeql

b7f509d

Contributor

github-actions bot commented Jun 12, 2022

Public API changes

💥 @spartacus/assets

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/cart/import-export/root

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/cart

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/checkout

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/core

Previous error: undefined
New error: ERROR: Failed to fetch entity for import() type node: import("@spartacus/core").Config

💥 @spartacus/epd-visualization/epd-visualization-api

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/product/bulk-pricing/occ

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/product

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/product/variants/occ

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/product-configurator

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/setup/ssr

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/tracking

Library no longer can be analyzed with api-extractor. Please check the errors:

💥 @spartacus/tracking/tms

Library no longer can be analyzed with api-extractor. Please check the errors:

⚠️ Some entry points are currently impossible to analyze.

Read more

@spartacus/asm/assets - ``
@spartacus/asm/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/asm/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/asm/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/asm - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/asm/root - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/assets - ``
@spartacus/cart/base/components/add-to-cart - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/components/mini-cart - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/base/root - ``
@spartacus/cart/import-export/assets - ``
@spartacus/cart/import-export/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/import-export/core - ``
@spartacus/cart/import-export - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/quick-order/assets - ``
@spartacus/cart/quick-order/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/quick-order/core - ``
@spartacus/cart/quick-order - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/quick-order/root - ``
@spartacus/cart/saved-cart/assets - ``
@spartacus/cart/saved-cart/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/saved-cart/core - ``
@spartacus/cart/saved-cart/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/saved-cart - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/saved-cart/root - ``
@spartacus/cart/wish-list/assets - ``
@spartacus/cart/wish-list/components/add-to-wishlist - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/wish-list/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cart/wish-list/core - ``
@spartacus/cart/wish-list - ``
@spartacus/cart/wish-list/root - ``
@spartacus/cdc/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cdc/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cdc - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/cdc/root - ERROR: Failed to fetch entity for import() type node: import("@spartacus/core").Config
@spartacus/cds - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/b2b/assets - ``
@spartacus/checkout/b2b/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/b2b/core - ``
@spartacus/checkout/b2b/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/b2b - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/b2b/root - ``
@spartacus/checkout/base/assets - ``
@spartacus/checkout/base/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/base/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/base/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/base - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/base/root - ``
@spartacus/checkout/scheduled-replenishment/assets - ``
@spartacus/checkout/scheduled-replenishment/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/scheduled-replenishment - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/checkout/scheduled-replenishment/root - ``
@spartacus/core - ERROR: Failed to fetch entity for import() type node: import("@spartacus/core").Config
@spartacus/digital-payments/assets - ``
@spartacus/digital-payments - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/epd-visualization/assets - ``
@spartacus/epd-visualization/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/epd-visualization/core - ``
@spartacus/epd-visualization - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/epd-visualization/root - ``
@spartacus/order/assets - ``
@spartacus/order/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/order/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/order/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/order - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/order/root - ``
@spartacus/organization/administration/assets - ``
@spartacus/organization/administration/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/organization/administration/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/organization/administration/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/organization/administration - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/organization/administration/root - ``
@spartacus/organization/order-approval/assets - ``
@spartacus/organization/order-approval - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/organization/order-approval/root - ``
@spartacus/organization - ``
@spartacus/product/bulk-pricing/assets - ``
@spartacus/product/bulk-pricing/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/bulk-pricing/core - ``
@spartacus/product/bulk-pricing - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/bulk-pricing/root - ``
@spartacus/product/image-zoom/assets - ``
@spartacus/product/image-zoom/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/image-zoom - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/image-zoom/root - ``
@spartacus/product/variants/assets - ``
@spartacus/product/variants/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/variants - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product/variants/root - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/common/assets - ``
@spartacus/product-configurator/common - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/rulebased/cpq - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/rulebased - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/rulebased/root - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/textfield - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/product-configurator/textfield/root - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/qualtrics/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/qualtrics - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/qualtrics/root - ``
@spartacus/setup - ``
@spartacus/smartedit/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/smartedit - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/smartedit/root - ``
@spartacus/storefinder/assets - ``
@spartacus/storefinder/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/storefinder/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/storefinder/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/storefinder - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/storefinder/root - ``
@spartacus/storefront - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/tracking/personalization/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/tracking/personalization - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/tracking/personalization/root - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/tracking/tms/aep - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/tracking/tms/core - ``
@spartacus/tracking/tms/gtm - ``
@spartacus/user/account/assets - ``
@spartacus/user/account/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/account/core - ``
@spartacus/user/account/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/account - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/account/root - ``
@spartacus/user - ``
@spartacus/user/profile/assets - ``
@spartacus/user/profile/components - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/profile/core - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/profile/occ - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/profile - ERROR: Internal Error: Unable to determine semantic information for declaration:
@spartacus/user/profile/root - ``

💰 How to debug problems?

Read more

Problem with import() type

It happens when type is deduced by TS based on code and at the same time the deduced type is not present in the file.
In this specific case to support api-extractor it's worth to add type declaration explicitly.

Debugging steps:

go to the bot action logs
find api-extractor logs for broken library
check in which file and line the problems exists
build the library locally and check content of the file mentioned in logs (look for import()
add explicit type to problematic source code
build the library once again and verify that the import( is no longer present
commit and push the code with defined type

giancorderoortiz added 2 commits

July 27, 2022 10:48


          Merge branch 'develop' into feature/GH-14925_enable_codeql

10890bf


          Merge branch 'develop' into feature/GH-14925_enable_codeql

d488c58

giancorderoortiz added the security label


          Merge branch 'develop' into feature/GH-14925_enable_codeql

b10a5ff

github-actions bot marked this pull request as draft

February 12, 2023 23:36

giancorderoortiz and others added 3 commits

March 23, 2023 11:14


          Merge branch 'develop' into feature/GH-14925_enable_codeql

a5eacf2


          upgrade codeql version to v2

76bba85


          Merge branch 'develop' into feature/GH-14925_enable_codeql

6695db7

Contributor

github-advanced-security bot commented Mar 27, 2023

You have successfully added a new CodeQL configuration .github/workflows/codeql-analysis.yml:analyze/language:typescript. As part of the setup process, we have scanned this repository and found 30 existing alerts. Please check the repository Security tab to see all alerts.


          Merge branch 'develop' into feature/GH-14925_enable_codeql

e2b7f37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels