Skip to content

Commit

Permalink
CXINT-2275: CDC \id_token\ missing in the Oauth token request (#17713)
Browse files Browse the repository at this point in the history
  • Loading branch information
SherwinVarghese authored Aug 1, 2023
1 parent dfeb244 commit ae9c559
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
4 changes: 1 addition & 3 deletions integration-libs/cdc/root/service/cdc-js.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ describe('CdcJsService', () => {
errorCallback: jasmine.any(Function) as any,
});
expect(winRef?.nativeWindow['__gigyaConf']).toEqual({
include: 'id_token',
include: 'id_token, missing-required-fields',
});
});

Expand Down Expand Up @@ -456,7 +456,6 @@ describe('CdcJsService', () => {
expect(service['gigyaSDK'].accounts.login).toHaveBeenCalledWith({
loginID: 'uid',
password: 'password',
include: 'missing-required-fields',
ignoreInterruptions: true,
sessionExpiry: sampleCdcConfig.cdc[0].sessionExpiration,
callback: jasmine.any(Function),
Expand Down Expand Up @@ -485,7 +484,6 @@ describe('CdcJsService', () => {
expect(service['gigyaSDK'].accounts.login).toHaveBeenCalledWith({
loginID: 'uid',
password: 'password',
include: 'missing-required-fields',
ignoreInterruptions: true,
context: 'RESET_EMAIL',
sessionExpiry: sampleCdcConfig?.cdc[0]?.sessionExpiration,
Expand Down
9 changes: 4 additions & 5 deletions integration-libs/cdc/root/service/cdc-js.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ import {
} from 'rxjs';
import { filter, switchMap, take, tap } from 'rxjs/operators';
import { CdcConfig } from '../config/cdc-config';
import { CdcAuthFacade } from '../facade/cdc-auth.facade';
import { CdcReConsentEvent } from '../events';
import { CdcSiteConsentTemplate } from '../consent-management/model/index';
import { CdcConsentsLocalStorageService } from '../consent-management';
import { CdcSiteConsentTemplate } from '../consent-management/model/index';
import { CdcReConsentEvent } from '../events';
import { CdcAuthFacade } from '../facade/cdc-auth.facade';

const defaultSessionTimeOut = 3600;
const setAccountInfoAPI = 'accounts.setAccountInfo';
Expand Down Expand Up @@ -124,7 +124,7 @@ export class CdcJsService implements OnDestroy {
(this.winRef.nativeWindow as { [key: string]: any })[
'__gigyaConf'
] = {
include: 'id_token',
include: 'id_token, missing-required-fields',
};
}
}
Expand Down Expand Up @@ -265,7 +265,6 @@ export class CdcJsService implements OnDestroy {
return this.invokeAPI('accounts.login', {
loginID: email,
password: password,
include: 'missing-required-fields',
ignoreInterruptions: ignoreInterruptions,
...(context && { context: context }),
sessionExpiry: sessionExpiration,
Expand Down

0 comments on commit ae9c559

Please sign in to comment.