feat: fix seller submit (CXSPA-4748) (#17855)

SAP · Sep 22, 2023 · 4409b78 · 4409b78
1 parent 5f28469
commit 4409b78
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/feature-libs/quote/assets/translations/en/quote.i18n.ts b/feature-libs/quote/assets/translations/en/quote.i18n.ts
@@ -130,10 +130,11 @@ export const quote = {
       },
       seller: {
         submit: {
-          title: 'Submit Quote {{ code }} for approval?',
-          confirmNote:
-            'Are you sure you want to submit this quote for approval?',
-          successMessage: 'Quote submitted for approval successfully',
+          title: 'Submit Quote {{ code }}?',
+          confirmNote: 'Are you sure you want to submit this quote?',
+          warningNote:
+            'Based on the total value of the quote an additional approval might be required, before the buyer can checkout this quote.',
+          successMessage: 'Quote submitted successfully',
         },
       },
       approver: {

diff --git a/feature-libs/quote/components/config/default-quote-ui.config.ts b/feature-libs/quote/components/config/default-quote-ui.config.ts
@@ -64,6 +64,7 @@ const defaultDialogMappings: ConfirmActionDialogMappingConfig = {
     SUBMIT: {
       i18nKey: 'quote.confirmActionDialog.seller.submit',
       ...defaultConfirmActionDialogConfig,
+      showWarningNote: true,
     },
   },
   SELLERAPPROVER: {

diff --git a/feature-libs/quote/core/facade/quote.service.spec.ts b/feature-libs/quote/core/facade/quote.service.spec.ts
@@ -419,13 +419,17 @@ describe('QuoteService', () => {
     });
 
     describe('on submit', () => {
-      it('should create new cart and navigate to quote list', (done) => {
+      it('should create new cart and navigate to quote list, but not reload', (done) => {
         service
           .performQuoteAction(quote, QuoteActionType.SUBMIT)
           .subscribe(() => {
             expect(
               cartUtilsService.createNewCartAndGoToQuoteList
             ).toHaveBeenCalled();
+            expect(eventService.dispatch).not.toHaveBeenCalledWith(
+              {},
+              QuoteDetailsReloadQueryEvent
+            );
             done();
           });
       });

diff --git a/feature-libs/quote/core/facade/quote.service.ts b/feature-libs/quote/core/facade/quote.service.ts
@@ -225,7 +225,7 @@ export class QuoteService implements QuoteFacade {
             payload.quoteAction === QuoteActionType.CANCEL
           ) {
             this.cartUtilsService.createNewCartAndGoToQuoteList();
-            this.triggerReloadAndCompleteAction();
+            this.isActionPerforming$.next(false);
           }
           if (
             payload.quoteAction === QuoteActionType.EDIT ||