fix: PDP pickup options a11y improvements

SAP · Aug 14, 2024 · 019f4a3 · 019f4a3
1 parent 31c3de9
commit 019f4a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...up-in-store/components/container/pickup-option-dialog/pickup-option-dialog.component.html b/...up-in-store/components/container/pickup-option-dialog/pickup-option-dialog.component.html
@@ -4,7 +4,6 @@
   (esc)="close(CLOSE_WITHOUT_SELECTION)"
   role="dialog"
   aria-modal="true"
-  aria-labelledby="cx-pickup-option-dialog-title"
 >
   <div class="cx-dialog-content">
     <!-- Modal Header -->

diff --git a/...bs/pickup-in-store/components/presentational/pickup-options/pickup-options.component.html b/...bs/pickup-in-store/components/presentational/pickup-options/pickup-options.component.html
@@ -1,8 +1,8 @@
-<form [formGroup]="pickupOptionsForm">
+<form [formGroup]="pickupOptionsForm" role="radiogroup">
   <div class="form-check">
     <input
       type="radio"
-      role="radio"
+      name="pickupOption"
       [attr.id]="deliveryId"
       data-pickup="delivery"
       value="delivery"
@@ -18,9 +18,9 @@
   <div class="form-check">
     <input
       type="radio"
-      role="radio"
       [attr.id]="pickupId"
       data-pickup="pickup"
+      name="pickupOption"
       value="pickup"
       (click)="onPickupOptionChange('pickup')"
       formControlName="pickupOption"