Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct padding for ObjectPageLayout showing title in header content on display class Desktop-XL #3960

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

patrickhuy
Copy link
Member

When ObjectPageLayout is set to showTitleInHeaderContent and the header is displayed with on a screen of class Desktop-XL the content area (and especially noticeable: the image) don't have a top padding.

This can be observed here: https://jsfiddle.net/395hrpye/ (the padding from the icon to top goes away when entering the Desktop-XL layout)

Bildschirmaufnahme.2024-01-30.um.15.12.19.mov

This PR applies the padding from Tablet and Desktop also for Desktop-XL in both the theme "horizon" as well as "quartz".

@patrickhuy patrickhuy changed the title Patch 1 Correct padding for ObjectPageLayout showing title in header content on display class Desktop-XL Jan 30, 2024
@flovogt
Copy link
Member

flovogt commented Jan 31, 2024

Hi @patrickhuy,
Thank you for sharing your enhancement proposal. I've created an internal incident DINC0053713. The responsible team will have handle this PR and post further updates here.

@codeworrior
Copy link
Member

Hi @flovogt, there's already DINC0053067 for the same issue. Shall we close DINC0053713 as a duplicate?

@flovogt
Copy link
Member

flovogt commented Jan 31, 2024

Duplicate DINC0053713 is closed. Thanks for pointing this out @codeworrior

@flovogt
Copy link
Member

flovogt commented Sep 30, 2024

This PR will be covered in backlog item BGSOFUIPIRIN-6105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants