fix: high severity sonar issues

[heimwege]

Fix high severity issues reported by sonar (skipping the cognitive complexity and dataset ones)

[changeset-bot]

⚠️ No Changeset found

Latest commit: d56d06b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[sonarqubecloud]

Quality Gate failed

Failed conditions
78.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[nikmace]

Started a job for preview-middleware changes just in case: open-ux-validation/1269 - seems to have a problem in the pipeline

[heimwege]

Started a job for preview-middleware changes just in case: open-ux-validation/1269 - seems to have a problem in the pipeline

Thanks @nikmace, the error does not look like it is related to the code changes. It's a 404 when trying to download ui5 cli. When I use that link is works perfectly fine. That causes all 72 CPE tests to fail. 171 ADP tests are fine though 🤷🏻 Any idea?

07:57:10    1) [CPE] › test/integration/CPE/001_Properties.spec.ts:75:13 › UI5 version - 1.143.0 › Step 1: Change Button Text 
07:57:10  
07:57:10      Error: npm warn using --force Recommended protections disabled.
07:57:10      npm error code E404
07:57:10      npm error 404 Not Found - GET <someInternalURL>/build-milestones-npm/@ui5/cli/-/cli-4.0.37.tgz
07:57:10      npm error 404
07:57:10      npm error 404  '@ui5/cli@<someInternalURL>/build-milestones-npm/@ui5/cli/-/cli-4.0.37.tgz' is not in this registry.
07:57:10      npm error 404
07:57:10      npm error 404 Note that you can also install from a
07:57:10      npm error 404 tarball, folder, http url, or git url.
07:57:10      npm error A complete log of this run can be found in: /home/piper/.npm/_logs/2025-12-02T06_52_13_042Z-debug-0.log
07:57:10  
07:57:10  
07:57:10         at helpers/scriptRunner.ts:88
07:57:10  
07:57:10        86 |         log({ message: `====> exit for command ${command}: ${spawnSyncProc.status}` });
07:57:10        87 |         const errorText = spawnSyncProc.stderr.toString();
07:57:10      > 88 |         throw new Error(errorText);
07:57:10           |               ^
07:57:10        89 |     }
07:57:10        90 |
07:57:10        91 |     const { output, error, stderr, stdout } = spawnSyncProc;
07:57:10          at runSyncScript (/home/jenkins/agent/workspace/open-ux-validation/uxTooling/packages/ui5-tooling/test/integration/helpers/scriptRunner.ts:88:15)
07:57:10          at /home/jenkins/agent/workspace/open-ux-validation/uxTooling/packages/ui5-tooling/test/integration/helpers/project/npm.ts:38:22
07:57:10  
07:57:10      TypeError: Cannot read properties of undefined (reading 'pid')
07:57:10  
07:57:10         at helpers/server/index.ts:54
07:57:10  
07:57:10        52 |  */
07:57:10        53 | const teardownServer = async (): Promise<void> => {
07:57:10      > 54 |     const pid = server.pid;
07:57:10           |                        ^
07:57:10        55 |     return new Promise((resolve) => {
07:57:10        56 |         if (!pid) {
07:57:10        57 |             return resolve(undefined);
07:57:10          at teardownServer (/home/jenkins/agent/workspace/open-ux-validation/uxTooling/packages/ui5-tooling/test/integration/helpers/server/index.ts:54:24)
07:57:10          at stop (/home/jenkins/agent/workspace/open-ux-validation/uxTooling/packages/ui5-tooling/test/integration/helpers/start.ts:26:29)
07:57:10          at /home/jenkins/agent/workspace/open-ux-validation/uxTooling/packages/ui5-tooling/test/integration/CPE/001_Properties.spec.ts:58:13
07:57:10  
07:57:10      attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────
07:57:10      test-results/001_Properties-UI5-version-cdaaf-0-Step-1-Change-Button-Text-CPE/trace.zip
07:57:10      Usage:
07:57:10  
07:57:10          yarn playwright show-trace test-results/001_Properties-UI5-version-cdaaf-0-Step-1-Change-Button-Text-CPE/trace.zip

[nikmace]

@heimwege I think the tests are OK for ADP at least. CPE tests has been failing for a couple of days.

[nikmace]

Changes look good from ADP side
Did not test manually

Probably needs a review from @voicis