Skip to content

fix(preview-middleware): i18n handling for cards generator #3736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix(preview-middleware): i18n handling for cards generator #3736

wants to merge 10 commits into from

Conversation

@Singham-24
Copy link

Fixes i18n key handling for CAP-based cards generator in preview-middleware.

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 3a3108a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cla-assistant
Copy link

cla-assistant bot commented Oct 15, 2025 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ heimwege
❌ Singham-24
You have signed the CLA already but the status is still pending? Let us recheck it.

@Singham-24 Singham-24 marked this pull request as ready for review October 15, 2025 14:16
@Singham-24 Singham-24 requested a review from a team as a code owner October 15, 2025 14:16
@heimwege heimwege added the preview-middleware @sap-ux/preview-middleware label Oct 16, 2025
heimwege
heimwege reviewed Oct 16, 2025
View reviewed changes
packages/preview-middleware/test/unit/base/flp.test.ts
const webappPath = await getWebappPath(path.resolve());
const expectedPath = join(webappPath, 'i18n', 'custom_de.properties');

describe('router with enableCardGenerator in CAP project', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CAP test cases should not be deleted in this PR. They are deleted as part of #3737. This PR only handles the i18n adjustments that are independent from the project type.

heimwege
heimwege reviewed Oct 16, 2025
View reviewed changes
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heimwege heimwege heimwege left review comments

@Sharmavksh Sharmavksh Awaiting requested review from Sharmavksh

@chaudhary1-rohit chaudhary1-rohit Awaiting requested review from chaudhary1-rohit

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

preview-middleware @sap-ux/preview-middleware

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Singham-24 @heimwege