Chore - Eslint 9 - devDependencies #3082

devinea · 2025-04-02T22:44:46Z

Chore - Eslint 9 - devDependencies only. Does no impact Fiori generated projects (that is in a follow-up PR's #3788 & #3827

Upgrade ESlint to V9
Upgrade eslint plugins to V9 compatible.
Replace config with new flat config.
Apply fixes or disable check for new update rules.
Replace migrated rules.
TEMP: Disable linting on preview-middeleware-client (will be re-nabled in refactor: Update ESLint configurations for ESLint 9 compatibility #3788 )

changeset-bot · 2025-04-02T22:44:51Z

🦋 Changeset detected

Latest commit: 0c2bd16

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 93 packages

Name	Type
@sap-ux/ui5-library-reference-sub-generator	Patch
@sap-ux/abap-deploy-config-sub-generator	Patch
@sap-ux/cds-odata-annotation-converter	Patch
@sap-ux/cf-deploy-config-sub-generator	Patch
@sap-ux-private/control-property-editor-common	Patch
@sap-ux/deploy-config-generator-shared	Patch
@sap-ux/ui5-library-reference-inquirer	Patch
@sap-ux/xml-odata-annotation-converter	Patch
@sap-ux/repo-app-import-sub-generator	Patch
@sap-ux/adp-flp-config-sub-generator	Patch
@sap-ux/ui5-library-reference-writer	Patch
@sap-ux/abap-deploy-config-inquirer	Patch
@sap-ux/deploy-config-sub-generator	Patch
@sap-ux/odata-annotation-core-types	Patch
@sap-ux-private/adaptation-editor-tests	Patch
@sap-ux/abap-deploy-config-writer	Patch
@sap-ux/cf-deploy-config-inquirer	Patch
@sap-ux/eslint-plugin-fiori-tools	Patch
@sap-ux-private/preview-middleware-client	Patch
@sap-ux/ui5-library-sub-generator	Patch
@sap-ux/backend-proxy-middleware	Patch
@sap-ux/flp-config-sub-generator	Patch
@sap-ux/mockserver-config-writer	Patch
@sap-ux/ui-service-sub-generator	Patch
@sap-ux/ui5-application-inquirer	Patch
@sap-ux/cf-deploy-config-writer	Patch
@sap-ux/control-property-editor	Patch
@sap-ux/fiori-app-sub-generator	Patch
@sap-ux/project-input-validator	Patch
@sap-ux/serve-static-middleware	Patch
@sap-ux/fiori-freestyle-writer	Patch
@sap-ux/fiori-generator-shared	Patch
@sap-ux/odata-service-inquirer	Patch
@sap-ux/sap-systems-ext-webapp	Patch
@sap-ux/ui5-application-writer	Patch
@sap-ux-private/ui-prompting-examples	Patch
@sap-ux/cds-annotation-parser	Patch
@sap-ux/fiori-docs-embeddings	Patch
@sap-ux/fiori-elements-writer	Patch
@sap-ux/guided-answers-helper	Patch
@sap-ux/jest-runner-puppeteer	Patch
@sap-ux/odata-annotation-core	Patch
@sap-ux/sap-systems-ext-types	Patch
@sap-ux/annotation-generator	Patch
@sap-ux/fiori-annotation-api	Patch
@sap-ux/fiori-tools-settings	Patch
@sap-ux/jest-environment-ui5	Patch
@sap-ux/odata-service-writer	Patch
@sap-ux/ui5-library-inquirer	Patch
@sap-ux/ui5-proxy-middleware	Patch
@sap-ux/flp-config-inquirer	Patch
@sap-ux/text-document-utils	Patch
@sap-ux/ui-service-inquirer	Patch
@sap-ux/jest-file-matchers	Patch
@sap-ux/odata-entity-model	Patch
@sap-ux/odata-vocabularies	Patch
@sap-ux/preview-middleware	Patch
@sap-ux/ui5-library-writer	Patch
@sap-ux/app-config-writer	Patch
@sap-ux/cap-config-writer	Patch
@sap-ux/environment-check	Patch
@sap-ux/project-integrity	Patch
@sap-ux/reload-middleware	Patch
@sap-ux/generator-simple-fe	Patch
@sap-ux/fiori-mcp-server	Patch
@sap-ux/axios-extension	Patch
@sap-ux/inquirer-common	Patch
sap-ux-sap-systems-ext	Patch
@sap-ux/ui5-test-writer	Patch
@sap-ux/deploy-tooling	Patch
@sap-ux/feature-toggle	Patch
@sap-ux/project-access	Patch
@sap-ux/fe-fpm-writer	Patch
@sap-ux/generator-adp	Patch
@sap-ux/launch-config	Patch
@sap-ux/system-access	Patch
@sap-ux/ui-components	Patch
@sap-ux/nodejs-utils	Patch
@sap-ux/ui-prompting	Patch
@sap-ux/adp-tooling	Patch
@sap-ux/fe-fpm-cli	Patch
@sap-ux-private/playwright	Patch
@sap-ux/ui5-config	Patch
@sap-ux/odata-cli	Patch
@sap-ux/btp-utils	Patch
@sap-ux/telemetry	Patch
@sap-ux/ui5-info	Patch
@sap-ux/create	Patch
@sap-ux/logger	Patch
@sap-ux/store	Patch
@sap-ux/i18n	Patch
@sap-ux/yaml	Patch
@sap-ux/types	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

* origin/main: Support sonar scans on forks (#3766) Chore add sonar workflow (#3775) chore: apply latest changesets fix: encode service url for RAP (#3784) chore: apply latest changesets fix(store): correction for merging systems added to legacy path (#3782) Update CODEOWNERS for fiori-mcp-server and eslint-plugin (#3780) chore: apply latest changesets fix(mcp-server): Pass 'layer' and 'ui5Version' to the specification API method exportConfig. (#3776) chore: apply latest changesets feat(store): migrate backend system file from .fioritools to .saptools (#3768)

* origin/main: chore: apply latest changesets 3792/handle missing mta binary (#3793) chore: apply latest changesets feat(sap-systems): adds new SAP Systems extension (#3752) chore: apply latest changesets fix(backend-proxy-middleware): wrong 'path' and 'pathReplace' in case of appStudio full destination (#3787)

* origin/main: (37 commits) chore: apply latest changesets chore - upgrade ui5 devDeps (#3771) correct publisher to SAPOSS (#3817) chore: apply latest changesets fix: cloud system render logic, message wording, test connection logging (#3811) chore: apply latest changesets chore: bump application insights to 2.9.8 (#3812) chore: apply latest changesets fix(fiori-mcp): instrumentation key replacement (#3810) lint error handling for forks fix: update repository reference in checkout step of lint workflow (#3808) chore: apply latest changesets chore: add badge to changelog and deep link to package to readme.md files (#3791) chore: apply latest changesets chore: update pipeline to publish extensions as draft (#3807) chore: apply latest changesets fix(fiori-annotation-api): move and delete (#3785) chore: apply latest changesets generalise pipeline config (#3804) chore: apply latest changesets ...

* origin/main: chore: apply latest changesets feat(create): auto generate readme on build (#3760) chore: apply latest changesets Resolve Transport Request Checks for Download Quick Fiori App Deploy (#3819) test: v4 project builder (#3682) chore: apply latest changesets fix: bump specVersion to v4.0 (#3744) chore: apply latest changesets test: Integration test for fiori MCP using promptfoo (#3705) chore: apply latest changesets fix: move message to store creds prompt, tests, changeset (#3820) chore: apply latest changesets fix: bump fallback versions (#3813)

* origin/main: chore: apply latest changesets update building block svg (#3826)

* origin/main: Move cpe integration test (#3783) chore: apply latest changesets fix(fiori-docs-embeddings): use existing ux-ui5-readme in case of error (#3830) chore: apply latest changesets feat(ADP)(OData): Display in the Info center the OData service connectivity status at startup of the Visual Editor. (#3560) Revert "fix: run tests on windows (#3823)" (#3835) fix for lint commit not starting the main build on the PR (#3833) chore: apply latest changesets Updating remaining ui5 cli references to v4 and align version (#3824) chore: apply latest changesets feat: Replace existing inbounds scenario now replaces all inbounds in FLP configuration generator for ADP (#3773) chore: apply latest changesets fix: improve handling for saving systems (#3828) chore: apply latest changesets chore: Update `@sap/cf-tools` version to latest to avoid security issues (#3809) chore: apply latest changesets feat(fiori-docs-embeddings): add @sap-ux/create/README.md as resource (#3779) fix: run tests on windows (#3823)

* origin/main: fix(deps): update dependency js-yaml [security] (#3840) chore: apply latest changesets fix(odata-service-inquirer): Validation messages for credential fail (#3815) chore: apply latest changesets sap-systems-ext: update extension name and readme (#3849) chore: apply latest changesets fix(sap-systems-ext): title update and import fix for sap systems ext (#3843) chore: apply latest changesets fix(odata-service-inq): add try catch to fetching backend systems from store (#3839) chore: apply latest changesets feat: Store view name as part of additional info in fragment body (#3696) chore: apply latest changesets feat(fpm-writer): Filter building block custom filter (#3767) chore: apply latest changesets fix(mcp-server): allow to create object pages in v2 (#3795) feat: add test cases for java project (#3825) chore: apply latest changesets fix: inlude require when generate custom field fragment with event handler (#3836)

* origin/main: chore: apply latest changesets fix: System SAPUI5 version not available for selection in ADP generator (#3851) chore: apply latest changesets Fix(preview-middleware): adjust fallback ui5 version (#3722)

* origin/eslint9: revert templates and snapshots

* origin/main: chore: apply latest changesets Fix(cap-config-writer): min cds version (#3856) feat: New public method for `ApplicationAccess` - `readManifest`, `readFlexChanges`, `readAnnotationFiles` (#3854)

* origin/main: chore: apply latest changesets feat: menu actions generator (#3521) chore: apply latest changesets chore: remove mkdirp usage and update dependencies (#3871) chore: apply latest changesets feat: save value list reference metadata (#3794) chore: apply latest changesets fix: alignment fallback ui5 versions (#3861) chore: apply latest changesets feat(fiori-app-sub-generator): 36139-remove-code-assist (#3860) chore: apply latest changesets chore - update sap-ux-odata deps (#3863)

sonarqubecloud · 2025-11-27T00:54:17Z

Quality Gate passed

Issues
1 New issue
8 Accepted issues

Measures
0 Security Hotspots
89.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

heimwege

see comments (part 1 up to package 'store')

heimwege · 2025-11-27T15:48:14Z

examples/ui-prompting-examples/eslint.config.js

+        },
+        languageOptions: {
+            parserOptions: {
+                parser: tsParser,


In other places (e.g. examples/simple-generator/eslint.config.js) we have parser: '@typescript-eslint/parser', but I like this notation with the import more. Should we harmonize this?

heimwege · 2025-11-27T15:51:02Z

examples/ui-prompting-examples/eslint.config.js

+        languageOptions: {
+            'parser': tsParser
+        },


Why do we have this multiple times in here? Can't this be merged into one?

heimwege · 2025-11-27T16:00:44Z

packages/axios-extension/src/factory.ts

 */
-// eslint-disable-next-line jsdoc/require-jsdoc
+
+/**


Best JSDoc ever. Please either delete or provide content 🐱

heimwege · 2025-11-27T16:02:42Z

packages/backend-proxy-middleware/test/base/proxy.test.ts

+import type { BackendSystem } from '@sap-ux/store';
+import { AuthenticationType } from '@sap-ux/store';


Suggested change

import type { BackendSystem } from '@sap-ux/store';

import { AuthenticationType } from '@sap-ux/store';

import { type BackendSystem, AuthenticationType } from '@sap-ux/store';

heimwege · 2025-11-27T16:05:51Z

packages/cards-editor-config-writer/eslint.config.js

@@ -0,0 +1,13 @@
+const base = require('../../eslint.config.js');


That package is deprecated (https://www.npmjs.com/package/@sap-ux/cards-editor-config-writer). Let's not do any changes here.

heimwege · 2025-11-27T16:52:35Z

packages/odata-vocabularies/package.json

+        "lint:fix": "eslint . --fix",
+        "lint:fix:all": "eslint . --fix",


fix = fix:all

heimwege · 2025-11-27T16:53:55Z

packages/preview-middleware-client/src/adp/controllers/AddFragment.controller.ts

@@ -38,10 +38,25 @@ import BaseDialog from './BaseDialog.controller';
 const radix = 10;

 export type AddFragmentModel = JSONModel & {
+    /**


JSDoc hell also for package preview-middleware-client

heimwege · 2025-11-27T16:56:48Z

packages/preview-middleware-client/eslint.config.js

+            jsdoc
+        },
+        rules: {
+            quotes: [


There are much more rules than before in the config? What happened here?

heimwege · 2025-11-27T17:00:47Z

packages/sap-systems-ext/src/panel/system/sytemPanel.ts

@@ -22,6 +22,15 @@ export class SystemPanel implements Disposable {
    readonly isGuidedAnswersEnabled: boolean = !!extensions.getExtension(GUIDED_ANSWERS_EXTENSION_ID);
    readonly disposeCallback?: DisposeCallback;

+    /**


again some JSDoc issues

heimwege · 2025-11-27T17:00:57Z

packages/sap-systems-ext/src/panel/panelManager.ts

@@ -7,18 +7,35 @@ import type { Disposable } from 'vscode';
 export class PanelManager<T extends Disposable> {
    readonly panels = new Map<string, T>();

+    /**


again some JSDoc issues in this file

heimwege

...and here the comments for packages store to the end

heimwege · 2025-11-28T08:32:03Z

packages/store/src/data-access/filesystem.ts

    constructor(logger: Logger, options: ServiceOptions = {}) {
        this.logger = logger;
        this.storeDirectory = basedir(options);
    }

+    /**


JSDoc hell in the store package as well

heimwege · 2025-11-28T08:33:23Z

packages/store/eslint.config.js

+                tsconfigRootDir: __dirname,
+                project: './tsconfig.eslint.json',
+            },
+        }


Also here JSDoc rules missing from former .eslintrc.js

heimwege · 2025-11-28T08:35:11Z

packages/telemetry/src/base/interceptor/index.ts

@@ -42,7 +42,6 @@ export const duration = (
    evtName: EventName,
    sampleRate: SampleRate
 ): Function => {
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any


Why is this no longer an issue? Should still be reported by the linter, right? Affects the whole telemetry package

heimwege · 2025-11-28T08:38:40Z

packages/ui-components/package.json

@@ -23,8 +23,8 @@
        "build": "npm-run-all -l -p build:extension build:copyfiles build:storybook",
        "build:extension": "tsc --build --pretty",
        "build:copyfiles": "copyfiles --up 1 \"./src/**/*.scss\" ./dist/",
-        "lint": "eslint . --ext .ts,.tsx",
-        "lint:fix": "eslint . --ext .ts,.tsx --fix",
+        "lint": "eslint .  ",


too many blanks... and do we even need the dot?

Suggested change

"lint": "eslint . ",

"lint": "eslint .",

heimwege · 2025-11-28T08:42:40Z

packages/ui5-library-reference-inquirer/test/unit/choices.test.ts

+import type { Manifest } from '@sap-ux/project-access';
+import { ReuseLibType } from '@sap-ux/project-access';


Suggested change

import type { Manifest } from '@sap-ux/project-access';

import { ReuseLibType } from '@sap-ux/project-access';

import { type Manifest, ReuseLibType } from '@sap-ux/project-access';

heimwege · 2025-11-28T08:45:13Z

packages/ui5-proxy-middleware/test/base/utils.test.ts

@@ -19,7 +19,7 @@ import type { ProxyConfig } from '../../src/base/types';
 import type { IncomingMessage } from 'http';
 import { NullTransport, ToolsLogger } from '@sap-ux/logger';
 import type { Manifest } from '@sap-ux/project-access';
-import type { ReaderCollection } from '@ui5/fs';
+import type { ReaderCollection } from '@ui5/fs'; // eslint-disable-line sonarjs/no-implicit-dependencies


Suggested change

import type { ReaderCollection } from '@ui5/fs'; // eslint-disable-line sonarjs/no-implicit-dependencies

// eslint-disable-next-line sonarjs/no-implicit-dependencies

import type { ReaderCollection } from '@ui5/fs';

heimwege · 2025-11-28T08:46:55Z

packages/xml-odata-annotation-converter/package.json

+        "lint:fix": "eslint . --fix",
+        "lint:fix:all": "eslint . --fix",


fix = fix:all

heimwege · 2025-11-28T08:48:43Z

tests/integration/adaptation-editor/package.json

@@ -21,6 +21,7 @@
        "@sap-ux-private/playwright": "workspace:*",
        "@sap-ux/project-access": "workspace:*",
        "@sap-ux/yaml": "workspace:*",
+        "@playwright/test": "1.56.1",


Where does that one come from? 🤔

heimwege · 2025-11-28T08:52:20Z

tests/integration/adaptation-editor/version.js

-const { writeFile } = require('fs/promises');
-const { join } = require('path');
-const { getUI5Versions } = require('@sap-ux/ui5-info');
+import { writeFile } from 'fs/promises';


Is that js file really treated as ESM? If not we can't use import this here.

heimwege · 2025-11-28T11:24:43Z

packages/eslint-plugin-fiori-tools/package.json

    },
    "devDependencies": {
-        "eslint": "8.57.0"
+        "eslint": "^9"


We should not do this here, right? adding eslint 9 for the eslint-plugin-fiori-tools package will be done in a separate PR

heimwege · 2025-11-28T11:25:37Z

.changeset/nasty-crews-explain.md

+'@sap-ux-private/adaptation-editor-tests': patch
+'@sap-ux/abap-deploy-config-writer': patch
+'@sap-ux/cf-deploy-config-inquirer': patch
+'@sap-ux/eslint-plugin-fiori-tools': patch


That one should not be in here

* origin/main: (31 commits) chore: remove outdated ui5 cli and specification artefacts from package.json files (#3874) chore: apply latest changesets chore(fiori-mcp): bump package versions (#3893) test: failing tests (#3886) chore: apply latest changesets fix(fiori-mcp): improve non-cap app-gen input schema (#3891) chore: apply latest changesets fix(middlewares): add 'express' as peerDependency for middlewares (#3879) chore: apply latest changesets Feat(fiori-docs-embeddings): enhance downloaded readme files for better chunking (#3831) chore: apply latest changesets fix(fpm-writer): unique ids in fragment (#3881) chore: apply latest changesets fix(fiori-mcp): fix missing dependency (#3885) chore: apply latest changesets fix(adp-tooling): remove hard coded usage of webapp folder name (#3873) chore: apply latest changesets chore(fiori-mcp): fix pipeline (#3880) chore: apply latest changesets feat(fiori-mcp-server): add generate-fiori-ui-odata-app functionality (#3570) ...

heimwege · 2025-12-04T06:49:29Z

There's a new package backend-proxy-middelware-cf that needs to be adjusted as well

devinea mentioned this pull request Jun 30, 2025

BUG - eslint-plugin-fiori-tools meets eslint 8 EOL #2470

Open

3 tasks

devinea added 2 commits October 28, 2025 13:58

Eslint 9 updates - WIP

1078612

test updates

374f0b0

devinea force-pushed the eslint9 branch from 7978686 to 374f0b0 Compare October 28, 2025 14:13

devinea and others added 15 commits October 30, 2025 15:39

Merge remote-tracking branch 'origin/main' into eslint9

dfda8ec

* origin/main: chore: apply latest changesets update building block svg (#3826)

revert templates and snapshots

890a303

Merge remote-tracking branch 'origin/main' into eslint9

59033ec

* origin/main: chore: apply latest changesets fix: System SAPUI5 version not available for selection in ADP generator (#3851) chore: apply latest changesets Fix(preview-middleware): adjust fallback ui5 version (#3722)

Merge remote-tracking branch 'origin/eslint9' into eslint9

e966402

* origin/eslint9: revert templates and snapshots

merge from main

491a222

disable linting on preview-middleware client

17e6b72

Merge remote-tracking branch 'origin/main' into eslint9

0aac5bd

* origin/main: chore: apply latest changesets Fix(cap-config-writer): min cds version (#3856) feat: New public method for `ApplicationAccess` - `readManifest`, `readFlexChanges`, `readAnnotationFiles` (#3854)

Linting auto fix commit

9b3a92f

refactor: adjust import order

07615ac

devinea changed the title ~~WIP - Eslint 9~~ Chore - Eslint 9 - devDependencies Nov 25, 2025

add cset

ec7ffaf

devinea marked this pull request as ready for review November 25, 2025 11:59

devinea requested review from a team as code owners November 25, 2025 11:59

devinea and others added 6 commits November 25, 2025 13:52

sonar issues

7f721b2

sonar fixes

f528afa

remove "--ext" - no longer supported in eslint 9

5fa8c72

Merge branch 'main' into eslint9

420970c

move rule to new file

2de3072

heimwege reviewed Nov 27, 2025

View reviewed changes

heimwege reviewed Nov 28, 2025

View reviewed changes

		import type { BackendSystem } from '@sap-ux/store';
		import { AuthenticationType } from '@sap-ux/store';

	import type { BackendSystem } from '@sap-ux/store';
	import { AuthenticationType } from '@sap-ux/store';
	import { type BackendSystem, AuthenticationType } from '@sap-ux/store';

		@@ -0,0 +1,13 @@
		const base = require('../../eslint.config.js');

		"lint:fix": "eslint . --fix",
		"lint:fix:all": "eslint . --fix",

		import type { Manifest } from '@sap-ux/project-access';
		import { ReuseLibType } from '@sap-ux/project-access';

	import type { Manifest } from '@sap-ux/project-access';
	import { ReuseLibType } from '@sap-ux/project-access';
	import { type Manifest, ReuseLibType } from '@sap-ux/project-access';

	import type { ReaderCollection } from '@ui5/fs'; // eslint-disable-line sonarjs/no-implicit-dependencies
	// eslint-disable-next-line sonarjs/no-implicit-dependencies
	import type { ReaderCollection } from '@ui5/fs';

Chore - Eslint 9 - devDependencies #3082

Are you sure you want to change the base?

Chore - Eslint 9 - devDependencies #3082

Uh oh!

Conversation

devinea commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

sonarqubecloud bot commented Nov 27, 2025

Quality Gate passed

Uh oh!

heimwege left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

heimwege left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

heimwege commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

devinea commented Apr 2, 2025 •

edited

Loading

changeset-bot bot commented Apr 2, 2025 •

edited

Loading