Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read feature toggles in control property editor #2467

Merged
merged 8 commits into from
Oct 16, 2024

Conversation

voicis
Copy link
Contributor

@voicis voicis commented Oct 16, 2024

  • enhance getAllFeatureToggles to also read TOOLSUITE_FEATURES environment variable
  • pass features to the Control Property Editor and Preview via attributes in HTML template

@voicis voicis added preview-middleware @sap-ux/preview-middleware preview-middleware-client control-property-editor @sap-ux/control-property-editor labels Oct 16, 2024
@voicis voicis requested review from a team as code owners October 16, 2024 08:42
Copy link

changeset-bot bot commented Oct 16, 2024

🦋 Changeset detected

Latest commit: 4e10dd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sap-ux/feature-toggle Patch
@sap-ux-private/preview-middleware-client Patch
@sap-ux/control-property-editor Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates to @sap-ux/feature-toggle looks good.
Covered by tests
changeset ✅

Copy link
Contributor

@marufrasully marufrasully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @voicis

  • Changes looks good
  • Great test coverage
  • Did not test it locally

Copy link

sonarcloud bot commented Oct 16, 2024

@voicis voicis merged commit 93ffe8d into main Oct 16, 2024
13 checks passed
@voicis voicis deleted the feat/cpe/feature-toggle branch October 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control-property-editor @sap-ux/control-property-editor preview-middleware @sap-ux/preview-middleware preview-middleware-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants