Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-lib-sub-gen): move app info file writing to writing phase #2463

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

cianmSAP
Copy link
Contributor

#2406

Moves the writing of the appInfo.json file to the writing phase

Copy link

changeset-bot bot commented Oct 14, 2024

🦋 Changeset detected

Latest commit: 95a2ad2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/project-access Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/adp-tooling Patch
@sap-ux/annotation-generator Patch
@sap-ux/app-config-writer Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cards-editor-middleware Patch
@sap-ux/create Patch
@sap-ux/environment-check Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/launch-config Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devinea devinea requested a review from a team as a code owner October 15, 2024 10:55
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are clear.
Changeset ✅

Copy link
Member

@kjose90 kjose90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅
code, changeset and test ✅

Copy link

sonarcloud bot commented Oct 16, 2024

@cianmSAP cianmSAP merged commit eb38e5b into main Oct 16, 2024
13 checks passed
@cianmSAP cianmSAP deleted the fix/2406/ui5-lib-gen-app-info branch October 16, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants