Feat/create command for variants configuration #2446
Conversation
…ools into feat/create-variantsConfig
…ools into feat/create-variantsConfig
| @@ -0,0 +1,16 @@ | |||
| import type { MiddlewareConfig as PreviewConfig } from '@sap-ux/preview-middleware'; | |||
|
|
|||
| export type FioriToolsDeprecatedPreviewConfig = { | |||
There was a problem hiding this comment.
@tobiasqueck There already exists a type that represents the deprecated config preview config in ui5-config/src/types/index.ts. That still seems to be used to generate outdated configs (see here). Do we need to address this in this PR as well? Or is this part of some generator adjustments that will come later because it seems to be used in app writer (here)?
There was a problem hiding this comment.
Should this type (and previewConfigOptions) be moved to preview middleware?
| try { | ||
| previewMiddleware = await getPreviewMiddleware(undefined, basePath); | ||
| } catch (error) { | ||
| //todo: what to do in case there is no ui5.yaml file? try FileName.Ui5MockYaml or FileName.Ui5LocalYaml as fallback? |
There was a problem hiding this comment.
@tobiasqueck you thoughts about potential fallbacks for RTA editor path?
|
PR introduces create command to add Configuration for Variants Creation.
Prerequisite for:
#2172