Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding @sap-ux/cf-deploy-config-inquirer #2436

Merged
merged 56 commits into from
Oct 16, 2024
Merged

adding @sap-ux/cf-deploy-config-inquirer #2436

merged 56 commits into from
Oct 16, 2024

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Oct 4, 2024 •
edited
Loading

#2450

Added cf-deploy-config-inquirer, which will be used CF deployment flows to support the following prompts;

  • A prompt will request the destination name.
  • If enabled, a prompt will ask whether to add a managed application router.
  • If enabled, a prompt will confirm if the user wants to overwrite any existing configuration.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c09639f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/cf-deploy-config-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

IainSAP
IainSAP reviewed Oct 14, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments...thx

@kjose90 kjose90 requested a review from IainSAP October 14, 2024 13:42
longieirl
longieirl approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
All comments and sonar issues addressed.
Will be validated further when consumed into tools-suite.

IainSAP
IainSAP approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kjose90

  • Comments addressed
  • Test cov is good
  • Did not test manually

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

donal-tobin-sap
donal-tobin-sap approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@donal-tobin-sap donal-tobin-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module looks to be good.

@donal-tobin-sap
Copy link
Contributor

  • check whether an entry in the codeowners also needs to be added

@kjose90 kjose90 merged commit 2fa3fda into main Oct 16, 2024
13 checks passed
@kjose90 kjose90 deleted the open-source-cf-inquirer branch October 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donal-tobin-sap donal-tobin-sap donal-tobin-sap approved these changes

@longieirl longieirl longieirl approved these changes

@IainSAP IainSAP IainSAP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjose90 @donal-tobin-sap @longieirl @IainSAP