Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: remove test/flpSandbox.html from fiori-*-writers in favor of preview middleware #2404

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heimwege
Copy link
Contributor

@heimwege heimwege commented Sep 24, 2024

Modify the fiori--writers in the open-ux-tools to not generate the test/flpSandbox.html anymore and add the preview middleware to the ui5.yaml files (v0.3)

todo: use

import { FileName, readUi5Yaml } from '@sap-ux/project-access';
//FileName.Ui5Yaml, FileName.Ui5MockYaml, FileName.Ui5LocalYaml

instead of yaml

Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: e45942c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@heimwege
Copy link
Contributor Author

heimwege commented Sep 24, 2024

@tobiasqueck is that what you had in mind for #971: Modify the fiori-*-writers in the open-ux-tools to not generate the test/flpSandbox.html anymore and add the preview middleware to the ui5*.yaml files (v0.3) or did I misunderstand this task?

@tobiasqueck
Copy link
Contributor

@heimwege yes, it goes in the right direction. Please check with @ytpo-lyne because she is working on providing the add preview middleware as reusable functionality that you should use here to update the yamls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants