fix: inital comments and fixes

[johannes-kolbe]

Draft PR for #2371 for testing/consumption

[changeset-bot]

🦋 Changeset detected

Latest commit: 72fb9a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@sap-ux/mockserver-config-writer	Patch
@sap-ux/odata-service-writer	Patch
@sap-ux/ui5-config	Patch
@sap-ux/create	Patch
@sap-ux/fiori-elements-writer	Patch
@sap-ux/fiori-freestyle-writer	Patch
@sap-ux/odata-service-inquirer	Patch
@sap-ux/generator-simple-fe	Patch
@sap-ux/abap-deploy-config-inquirer	Patch
@sap-ux/abap-deploy-config-writer	Patch
@sap-ux/adp-tooling	Patch
@sap-ux/app-config-writer	Patch
@sap-ux/cards-editor-config-writer	Patch
@sap-ux/deploy-tooling	Patch
@sap-ux/environment-check	Patch
@sap-ux/launch-config	Patch
@sap-ux/project-access	Patch
@sap-ux/telemetry	Patch
@sap-ux/ui5-application-writer	Patch
@sap-ux/ui5-library-reference-writer	Patch
@sap-ux/ui5-library-writer	Patch
@sap-ux/ui5-proxy-middleware	Patch
@sap-ux/preview-middleware	Patch
@sap-ux/annotation-generator	Patch
@sap-ux/cap-config-writer	Patch
@sap-ux/cards-editor-middleware	Patch
@sap-ux/fe-fpm-writer	Patch
@sap-ux/fiori-annotation-api	Patch
@sap-ux/fiori-generator-shared	Patch
@sap-ux/ui5-application-inquirer	Patch
@sap-ux/ui5-library-reference-inquirer	Patch
@sap-ux/fe-fpm-cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[johannes-kolbe]

Hi @broksy please feel free to create your own PR with the changes. This was just to initially add the changes.

Feedback from testing and consuming on tools-suite side:

• ui5-mock.yaml services seems ok now with fix
  • metadataPath and mockdataPath should not be created
• ui5-local.yaml still gets several sap-fe-mockserver created
• ui5.yaml if two different systems are used for creation, currently syntax is wrong

      backend:
        - - path: /sap
            url: https://...
          - path: /sap
            url: https://...
            client: '000'
  

• manifest.json creation with 2 systems not correct

Will extend the symptoms with further testing. Also not sure which parts are open-source related and which from consumer side