Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sapuxlayer to package json #2359

Merged
merged 8 commits into from
Sep 18, 2024
Merged

Add sapuxlayer to package json #2359

merged 8 commits into from
Sep 18, 2024

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Sep 12, 2024

#2326

  • added sapuxType to ui5-application-writer package interface
  • added tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: edec0b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kjose90 kjose90 marked this pull request as ready for review September 12, 2024 08:27
@kjose90 kjose90 requested review from a team as code owners September 12, 2024 08:27
IainSAP
IainSAP previously approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @kjose90

  • Cleanly adds support for sapuxlayer property
  • Adds tests to cover

longieirl
longieirl approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Appropiate tests to cover change.
No chanageset required, being merged into a larger PR.

@IainSAP IainSAP dismissed their stale review September 12, 2024 08:43

Needs comment on new property

Klaus-Keller
Klaus-Keller reviewed Sep 17, 2024
View reviewed changes
Copy link
Contributor

@Klaus-Keller Klaus-Keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also changeset is missing

@kjose90
Copy link
Member Author

kjose90 commented Sep 17, 2024

Also changeset is missing

Its being merged into a large PR and PR is against a feature branch.

@Klaus-Keller
Copy link
Contributor

Also changeset is missing

Its being merged into a large PR and PR is against a feature branch.

Missed that, my bad.

@kjose90 kjose90 merged commit fe1c8d2 into start-variants-management-script Sep 18, 2024
2 checks passed
@kjose90 kjose90 deleted the add-sapuxLayer branch September 18, 2024 13:46
@kjose90
Copy link
Member Author

kjose90 commented Sep 18, 2024

Thanks for review

kjose90 added a commit that referenced this pull request Sep 23, 2024
@kjose90 @IainSAP
@longieirl @devinea
Add scripts variant management script to FF & FE package json (#2327)
484195d 
* add scripts variant management

* adding changeset

* fix vairant script

* update snapshots

* changing disableCacheParam var name

* Add sapuxlayer to package json  (#2359)

* add sapuxlayer

* document sapuxLayer property

* update snap shots and set default sapuxLayer

* update test name

* Update index.ts fix typp

* reverting default sap ux layer settings

* use package type from project-access in ui5-application-writer

* Add ignore cert error to odata-service-writer  (#2343)

* add ignore cert error to odata service writer and ui5 config

* lint issues

* Add fiori-tools-preview middleware to ui5 yamls (#2382)

* update fiori preview middleares

* add fiori preview & update snapshots

* add doc to firori middlware type

* Create thin-numbers-repair.md

* Delete .changeset/thin-numbers-repair.md

---------

Co-authored-by: Austin Devine <[email protected]>

* adding default app name to simple generator example app

* update changeset

* snapshot fix

* sonar issue

---------

Co-authored-by: IainSAP <[email protected]>
Co-authored-by: J Long <[email protected]>
Co-authored-by: Austin Devine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longieirl longieirl longieirl approved these changes

@Klaus-Keller Klaus-Keller Klaus-Keller approved these changes

@IainSAP IainSAP Awaiting requested review from IainSAP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjose90 @Klaus-Keller @longieirl @IainSAP