Remove odata service inquirer dependency from launch config #2338
Conversation
🦋 Changeset detectedLatest commit: c02e5b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
| metadataFile = 'metadataFile' | ||
| } | ||
|
|
||
| export enum OdataVersion { |
There was a problem hiding this comment.
Please use a type from a common module. Maybe project access? OdataVersion is already imported here we can use that instead:
| @@ -60,6 +59,17 @@ export interface LaunchConfigInfo { | |||
| filePath: string; | |||
| } | |||
|
|
|||
| export enum DatasourceType { | |||
There was a problem hiding this comment.
Please consider renaming this to something specific to launch config as it could be confused with the odata-service-inquirer datasource type which is a different concept. I'd suggest something like:
type startScriptType = 'cds' | 'mockServer'
I cant find any reference to 'odataServiceUrl' so I guess its not needed?
#31230