fix(ui5-app-inq): Checks if folderPath contains existing Fiori project #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f2f7063 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
martinjanus-sap
changed the title
|
Root of fiori app found, if nested within. |
|
IainSAP
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Thanks @martinjanus-sap
- Code is clear, well doc'd and properly extended from previous implementation using options
- New tests added to cover new functionality
longieirl
approved these changes
Sep 11, 2024
devinea
approved these changes
Sep 12, 2024
martinjanus-sap
deleted the
fix/ui5-app-inq/2316/folder-path-omit-existing-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2316
Validates provided path does not contain a Fiori project, appropriate validation message displayed:
The project folder path already contains an SAP Fiori application. Please choose a different folder and try again.