-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/2007/create cf deploy config writer #2139
base: main
Are you sure you want to change the base?
Conversation
…/create-deploy-config-writer
…/create-deploy-config-writer
🦋 Changeset detectedLatest commit: 96144a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New module structure set-up looks good.
ui5-config changes look good.
changeset should be updated.
I haven't reviewed the cf-deploy-config-writer logic in detail, but it looks clear and well structured.
.changeset/honest-poets-sniff.md
Outdated
@@ -0,0 +1,8 @@ | |||
--- | |||
'@sap-ux/cf-deploy-config-writer': patch | |||
'@sap-ux/project-access': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'@sap-ux/project-access': patch |
no project-access changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
.changeset/honest-poets-sniff.md
Outdated
'@sap-ux/cf-deploy-config-writer': patch | ||
'@sap-ux/project-access': patch | ||
'@sap-ux/ui5-config': patch | ||
'@sap-ux/telemetry': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'@sap-ux/telemetry': patch | |
'@sap-ux/telemetry': patch |
telemetry are only tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
…/create-deploy-config-writer
…:SAP/open-ux-tools into feature/2007/create-deploy-config-writer
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is well structured and documented
Coverage > 90%
Changeset ✅
Fix for #2007
a. Add CF deployment config to an existing HMTL5 application
b. To generate a base CF config i.e. standalone or managed
MtaConfig
class will provide a wrapper for the@sap/mta-lib
to editmta.yaml
files used in the CF generation flow.