Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2007/create cf deploy config writer #2139

Open
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

longieirl
Copy link
Contributor

Fix for #2007

  • Introduce a new cf-deploy-config-writer, will be used CF deployment flows to support the following;
    a. Add CF deployment config to an existing HMTL5 application
    b. To generate a base CF config i.e. standalone or managed
  • MtaConfig class will provide a wrapper for the @sap/mta-lib to edit mta.yaml files used in the CF generation flow.

@longieirl longieirl self-assigned this Jul 10, 2024
Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: 96144a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@sap-ux/cf-deploy-config-writer Patch
@sap-ux/ui5-config Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/abap-deploy-config-writer Patch
@sap-ux/adp-tooling Patch
@sap-ux/app-config-writer Patch
@sap-ux/cards-editor-config-writer Patch
@sap-ux/create Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/launch-config Patch
@sap-ux/mockserver-config-writer Patch
@sap-ux/odata-service-writer Patch
@sap-ux/project-access Patch
@sap-ux/telemetry Patch
@sap-ux/ui5-application-writer Patch
@sap-ux/ui5-library-reference-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/ui5-proxy-middleware Patch
@sap-ux/preview-middleware Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/annotation-generator Patch
@sap-ux/cap-config-writer Patch
@sap-ux/cards-editor-middleware Patch
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-annotation-api Patch
@sap-ux/fiori-generator-shared Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/fe-fpm-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@longieirl longieirl requested review from a team as code owners July 12, 2024 14:47
Copy link

sonarcloud bot commented Jul 31, 2024

Copy link

sonarcloud bot commented Sep 2, 2024

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New module structure set-up looks good.
ui5-config changes look good.
changeset should be updated.
I haven't reviewed the cf-deploy-config-writer logic in detail, but it looks clear and well structured.

@@ -0,0 +1,8 @@
---
'@sap-ux/cf-deploy-config-writer': patch
'@sap-ux/project-access': patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@sap-ux/project-access': patch

no project-access changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

'@sap-ux/cf-deploy-config-writer': patch
'@sap-ux/project-access': patch
'@sap-ux/ui5-config': patch
'@sap-ux/telemetry': patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'@sap-ux/telemetry': patch
'@sap-ux/telemetry': patch

telemetry are only tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link

sonarcloud bot commented Oct 17, 2024

Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is well structured and documented
Coverage > 90%
Changeset ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants