Changes to make JPAAbstractExpandQuery available for extension #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature added: To support the addition of custom SQL Hint to the search query.
Approach considered: Upon trying out different options, we have chosen to extend JPAAbstractExpandQuery and add our custom hint during execute() method call.
Overview of the changes: The current design (especially modifiers) of JPAAbstractExpandQuery doesn`t fully support extension since the Class by itself is public, but the important methods that are used within an extention
and other dependent classes have package private access. So the changes are specific to the classes or methods that are involved in supporting the mentioned feature.
@wog48, Please review the PR. If you have another approach to enabling the above feature, we are open to considering it.