Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid #344

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Grid #344

wants to merge 5 commits into from

Conversation

BerSie
Copy link
Member

@BerSie BerSie commented Sep 13, 2024

first version

Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Internal repo deleted.)

Comment on lines +730 to +733
<ComplexType Name="DataFieldMeasures" BaseType="UI.DataFieldGridAbstract">
<Annotation Term="Core.Description" String="A structured piece of data described by an annotation" />
<Property Name="Measures" Type="Collection(Edm.PropertyPath)" Nullable="false" />
</ComplexType>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One DataFieldMeasures already contains several measures, and in addition to that you can have several DataFieldMeasuress in UI.Grid/Columns. Why these nested collections?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not intented - thanks for the hint

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you haven't changed it yet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there can be only one datafieldmeasures either in columns or in rows. I'm struggling with the definition of the rows in columns as there either can dimensions and measures there, but measures can either be in the rows or in columns and there are always all together, dimensions can be spread over columns and rows. And of course the measure collection doesn't have a fixed position :-).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you haven't changed it yet.

Because I had to think about it :-) - I'm not as fast as you.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you haven't changed it yet.

Because I had to think about it :-) - I'm not as fast as you.

And if you have an idea how to solve the dilemma, don't hesitate to publish it...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there can be only one datafieldmeasures either in columns or in rows

Sounds complicated. Do you have examples, ideally with visuals of the corresponding grids?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will send you (both) an email with a screen shot.

Copy link
Contributor

@HeikoTheissen HeikoTheissen Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there can be only one datafieldmeasures either in columns or in rows. I'm struggling with the definition of the rows in columns as there either can dimensions and measures there, but measures can either be in the rows or in columns and there are always all together, dimensions can be spread over columns and rows. And of course the measure collection doesn't have a fixed position :-).

Let the UI.Grid have properties Rows and Columns, which can each contain

  1. UI.ReferenceFacets pointing to a UI.FieldGroupDimensions with UI.DataFields with groupable values
  2. a UI.ReferenceFacet pointing to a UI.FieldGroupMeasures with UI.DataFields with aggregatable values
  3. a UI.ReferenceFacet pointing to a UI.CollectionFacet containing UI.ReferenceFacets pointing to Analytics.StructureElements

and specify the integrity conditions that # 2 must occur exactly once overall and # 3 at most once overall.

See #345

vocabularies/UI.xml Outdated Show resolved Hide resolved
vocabularies/UI.xml Show resolved Hide resolved
vocabularies/UI.xml Outdated Show resolved Hide resolved
</ComplexType>
<ComplexType Name="DataFieldDimension" BaseType="UI.DataFieldGridAbstract">
<Annotation Term="Core.Description" String="A structured piece of data described by an annotation" />
<Property Name="Dimensions" Type="Edm.PropertyPath" Nullable="false" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Property Name="Dimensions" Type="Edm.PropertyPath" Nullable="false" />
<Property Name="Dimension" Type="Edm.PropertyPath" Nullable="false" />

Complex type name is singular, and type is also just one property path

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I missed that, when I changed the type name from plural to singular

@ralfhandl
Copy link
Member

What actually is a "data grid", and why isn't it just another ChartType?

<EnumType Name="ChartType">
<Member Name="Column" />
<Member Name="ColumnStacked" />
<Member Name="ColumnDual" />
<Member Name="ColumnStackedDual" />
<Member Name="ColumnStacked100" />
<Member Name="ColumnStackedDual100" />
<Member Name="Bar" />

@BerSie
Copy link
Member Author

BerSie commented Sep 13, 2024

What actually is a "data grid", and why isn't it just another ChartType?

<EnumType Name="ChartType">
<Member Name="Column" />
<Member Name="ColumnStacked" />
<Member Name="ColumnDual" />
<Member Name="ColumnStackedDual" />
<Member Name="ColumnStacked100" />
<Member Name="ColumnStackedDual100" />
<Member Name="Bar" />

I'm not an expert on that, but a grid has rows and columns which can be flexibly arranged using measures and dimensions (and there is something in addition we left out in the first version, which seems to be called structural properties, which are filter conditions on meaasures - if I got that correctly). So, simply a new chart type wouldn't suffice these requirements.

@HeikoTheissen
Copy link
Contributor

HeikoTheissen commented Sep 13, 2024

What actually is a "data grid", and why isn't it just another ChartType?

A grid cannot show its full power by making OData requests at runtime, it needs InA for that. The purpose of this pull request is only to define a grid through OData annotations (design time), not offer an OData service for the runtime.

This could be expressed by having an annotated entity type in the CSDL document, but no entity container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants