Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require namespace-qualified names in string values #281

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

ralfhandl
Copy link
Member

No description provided.

Copy link

@drktfl drktfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if the UI5 model implements alias resolution with the help of a "hardcoded" list of term (property) names. Such a list can be built automatically (during UI5 build) with the help of the Node.js function from #280.

@uhlmannm
Copy link
Member

uhlmannm commented Sep 6, 2023

I'd prefer if the UI5 model implements alias resolution with the help of a "hardcoded" list of term (property) names. Such a list can be built automatically (during UI5 build) with the help of the Node.js function from #280.

@HeikoTheissen Yes, but your proposal is really something bigger, in particular if we include an automation using the UI5 build.

@HeikoTheissen HeikoTheissen merged commit 915c314 into main Sep 7, 2023
3 checks passed
@HeikoTheissen HeikoTheissen deleted the fix/namespace-qualified-names-in-strings branch September 7, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants