Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: allow some UI annotations on type definitions #242

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: allow some UI annotations on type definitions #242

wants to merge 2 commits into from

Conversation

ralfhandl
Copy link
Member

@ralfhandl ralfhandl commented Mar 21, 2023 •
edited
Loading

Allow some UI annotations also on type definitions - CAP CDS supports type definitions

Intentionally do not add TypeDefinition for "hidden" or property-/parameter-specific annotations.

HeikoTheissen
HeikoTheissen reviewed Mar 21, 2023
View reviewed changes
Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment •
edited by ralfhandl
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about

  • Hidden
  • HiddenFilter
  • AdaptationHidden
  • DataFieldDefault
  • ParameterDefaultValue
  • RecommendationState
  • ExcludeFromNavigationContext?

@ralfhandl
Copy link
Member Author

Those are the ones meant by

Intentionally do not add TypeDefinition for "hidden" or property-/parameter-specific annotations.

Thanks for explicitly listing them

@ralfhandl
Copy link
Member Author

RecommendationState does not have an AppliesTo list.

@BerSie: can you check where it is expected/considered?

@BerSie
Copy link
Member

BerSie commented Mar 21, 2023

@BerSie: can you check where it is expected/considered?

I don't know - I have to ask team members who is using it and how... if it's used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeikoTheissen HeikoTheissen HeikoTheissen left review comments

@BerSie BerSie Awaiting requested review from BerSie

@UweSchwerk UweSchwerk Awaiting requested review from UweSchwerk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralfhandl @BerSie @HeikoTheissen