Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetrieveFunction and UpdateAction for aggregated entities #212

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

RetrieveFunction and UpdateAction for aggregated entities #212

wants to merge 39 commits into from

Conversation

HeikoTheissen
Copy link
Contributor

@HeikoTheissen HeikoTheissen commented Dec 15, 2022 •
edited
Loading

Based on these data:

OData V2:

GET Sales?$expand=Customer,Product&$select=Customer/Country,Product/Name,Amount

OData V4:

GET Sales?$apply=groupby((Customer/Country,Product/Name),aggregate(Amount))
Customer/Country Product/Name Amount
Netherlands Paper 3
Netherlands Sugar 2
USA Coffee 12
USA Paper 5
USA Sugar 2

@HeikoTheissen HeikoTheissen mentioned this pull request Dec 15, 2022
Closed
ralfhandl
ralfhandl reviewed Dec 15, 2022
View reviewed changes
Copy link
Member

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a matching JSON example of an aggregation result with instance annotations.

vocabularies/Analytics.xml Outdated Show resolved Hide resolved
ralfhandl
ralfhandl previously approved these changes Dec 15, 2022
View reviewed changes
@HeikoTheissen HeikoTheissen changed the base branch from main to aggregation-cs03-release-candidate February 16, 2023 15:07
HeikoTheissen
HeikoTheissen commented Mar 3, 2023
View reviewed changes
examples/Analytics.UpdateAction-sample.xml Outdated
Comment on lines 43 to 48
<Parameter Name="Updates" Type="SalesModel.Sale" Nullable="false">
<Annotation Term="Core.Description" String="Aggregate entity with nested properties that are to be updated, like the body of a PATCH request" />
</Parameter>
<ReturnType Type="SalesModel.Sale" Nullable="false">
<Annotation Term="Core.Description" String="Aggregate entity with updates applied" />
</ReturnType>
Copy link
Contributor Author

@HeikoTheissen HeikoTheissen Mar 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-nullable properties that have been aggregated away will be absent in the parameter Updates and in the return value. This is allowed by [OData-Aggr, section 3.1.1].

@HeikoTheissen HeikoTheissen changed the title UpdateAction RetrieveFunction and UpdateAction for aggregated entities Mar 16, 2023
@HeikoTheissen
AppliesTo
2013a73
@HeikoTheissen
Merge remote-tracking branch 'origin/main' into
7b81c5a 
aggregation-cs03-release-candidate
@HeikoTheissen
Merge remote-tracking branch 'origin/main' into aggregation-cs03-rele…
b9b8ea3 
…ase-candidate
@HeikoTheissen
OptionalParameter cannot have default value []
a9c1de8
@HeikoTheissen
Merge remote-tracking branch 'origin/main' into aggregation-cs03-rele…
bd83e11 
…ase-candidate
@HeikoTheissen
Merge remote-tracking branch 'origin/main' into aggregation-cs03-rele…
38eacf5 
…ase-candidate
@HeikoTheissen
Expand all levels (#237)
691b6d1
@HeikoTheissen
Merge remote-tracking branch 'origin/main' into aggregation-cs03-rele…
9e30fc1 
…ase-candidate
@HeikoTheissen
Merge branch 'aggregation-cs03-release-candidate' of [email protected]:S…
9500b9c 
…AP/odata-vocabularies.git into aggregation-cs03-release-candidate
@HeikoTheissen
Actions for creating and moving hierarchy nodes (#247)
47ad2a4
@HeikoTheissen
Action -> Function
66a9c92
@HeikoTheissen
auto-refreshed
141e7d3
@HeikoTheissen
Merge remote-tracking branch 'origin/aggregation-cs03-release-candidate'
58c7d54 
into updateAction
@HeikoTheissen
Merge branch 'updateAction' of [email protected]:SAP/odata-vocabularies.git
650cdab 
into updateAction
@HeikoTheissen
entity type -> entity set
a3eb69b
@HeikoTheissen
Instance annotations for recursive hierarchies (#258)
a199ef7
@HeikoTheissen
NextSibling has complex type
c79bbb9
@HeikoTheissen
Common.QualifiedName
2cc2758
@HeikoTheissen
Merge remote-tracking branch 'origin/aggregation-cs03-release-candidate'
71921da 
into updateAction
@HeikoTheissen
revert
d731fa4
@HeikoTheissen
revert
004c094
Base automatically changed from aggregation-cs03-release-candidate to main October 20, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralfhandl ralfhandl ralfhandl left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HeikoTheissen @ralfhandl