Calendar weeks are locale-dependent

[HeikoTheissen]

To be further discussed in Albatross meeting.

Supplementary Bibliography: The Week. By David Henkin

[HeikoTheissen]

Shouldn't every term that applies to a Parameter also apply to ReturnType?

[ralfhandl]

Shouldn't every term that applies to a Parameter also apply to ReturnType?

The term Core.OptionalParameter probably should not apply to ReturnType 😄

[HeikoTheissen]

The term Core.OptionalParameter probably should not apply to ReturnType 😄

I mean all the IsSomething tags, for example.

[ralfhandl]

I mean all the IsSomething tags, for example.

Good point, let's check those and extend their applicability where necessary.

[ralfhandl]

The "fiscal" terms were introduced by @GeraldKrause, he should also review this PR.

[GeraldKrause]

Why remove the regexp's from the fiscal terms? They are also given for calendar terms. In the end, they formally define the range of valid values and can be applied by an implementation for validation.

[HeikoTheissen]

Why remove the regexp's from the fiscal terms? They are also given for calendar terms. In the end, they formally define the range of valid values and can be applied by an implementation for validation.

Are you sure that their value range is identical to that of a calendar week? (After learning that there is a calendar week 54, I am not so sure about my knowledge in this area any more.)

[GeraldKrause]

Why remove the regexp's from the fiscal terms? They are also given for calendar terms. In the end, they formally define the range of valid values and can be applied by an implementation for validation.

Are you sure that their value range is identical to that of a calendar week? (After learning that there is a calendar week 54, I am not so sure about my knowledge in this area any more.)

You are right. I checked my mail conversation with Thomas Schneider, subject matter expert in S/4 and found a mail from 2019 where the CDS ABAP Core Annotation spec for fiscalweek and fiscalyearweek also mention the WW pattern and the states for the latter: "The last two digits represent the fiscal week in the year." So, your update reflects this and the previous description for this term was more restrictive than needed.