-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return 200 (not 204) for PUT requests to entity verticles #326
Conversation
2b224d5
to
ec66efd
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
In the last NeonBee Committer Meeting we discussed this PR with @kristian . We came to the following conclusion: -> Responds with a Location Header / Hint, use Location as returned by EntityVerticle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only found the two typos in the doc. Implementation looks good to me :)
I created #374 to tackle the leftovers of Pascals comment. As agreed in the last committer meeting, we split the implementation.
5657835
to
fe4b703
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
No description provided.