Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make health checks addable via SPI #140

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Make health checks addable via SPI #140

merged 1 commit into from
Jul 12, 2022

Conversation

s4heid
Copy link
Contributor

@s4heid s4heid commented Jun 13, 2022

Depends on #136 and #139

@s4heid s4heid added the enhancement New feature or request label Jun 13, 2022
@s4heid s4heid marked this pull request as ready for review July 7, 2022 12:37
@s4heid s4heid requested a review from a team as a code owner July 7, 2022 12:37
pk-work
pk-work approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@pk-work pk-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we should open an issue because this is now the 4th variant of loading classes during runtime. We should open an issue to remove this technical debt and check if we can have one unified way of loading classes at runtime.

@s4heid s4heid merged commit 71e754e into main Jul 12, 2022
@s4heid s4heid deleted the feat/health-spi branch July 12, 2022 14:41
@pk-work
Copy link
Contributor

pk-work commented Jul 12, 2022

Approved, but we should open an issue because this is now the 4th variant of loading classes during runtime. We should open an issue to remove this technical debt and check if we can have one unified way of loading classes at runtime.

#149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pk-work pk-work pk-work approved these changes

Assignees

@pk-work pk-work

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s4heid @pk-work