Fix logout flaky test

[ndricimrr]

Yet another attempt...

Seems like for some unexplicable reason the login function is not found.

So I removed it.

Check Test Video Recording here

Fixes #3884

[walmazacn]

It seems the linked failed test is based on older test definition and template:

it('Logout and login again', () => {
  cy.login('[email protected]', 'tets');

  //logout
  cy.get('[data-testid="luigi-topnav-profile"]').click();
  cy.contains('Sign Out').click();
  cy.get('[data-testid="logout-headline"]').should('contain', 'You have successfully logged out');
  cy.get('[data-testid="logout-message"]').should('contain', 'Sign in again to continue working on awesome things!');
  cy.expectPathToBe('/logout.html');

  //login again
  cy.contains('Re-Login').click();
  cy.expectPathToBe('/assets/auth-mock/login-mock.html', 5000);
  cy.get('body').should('contain', 'Login to Luigi sample app');
  cy.login('[email protected]', 'tets');
})

Compare it with the latest version of this test (5000ms timeout shouldn't be there):
https://github.com/SAP/luigi/blob/main/test/e2e-test-application/cypress/e2e/tests/1-angular/login-flow-nav-dropdown.cy.js#L69

That's why I'd wait until more tests run and then we can draw some conclusions

[ndricimrr]

Yes. True. It seems like we need to wait until next version after "2.16.0" gets released, to see it.

[ndricimrr]

wait for next release and reconsider this if still flaky