Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable option to hide the X button in a modal #3898

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer self-assigned this Sep 9, 2024
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Sep 9, 2024
@JohannesDoberer JohannesDoberer removed their assignment Sep 9, 2024
>
<i class="sap-icon sap-icon--decline" />
</button>
{#if settings.hideXBtn !== true}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add this option to the docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do.

@walmazacn walmazacn self-assigned this Sep 9, 2024
@JohannesDoberer
Copy link
Contributor Author

Need to be clarified with the technical guys from hyperspace portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants