-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify the difference between attributes and properties #3856
base: main
Are you sure you want to change the base?
Conversation
not sure if this is supposed to be in the source code somewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added snippets for the compound container, if this looks ok I can add snippets to the other API reference as well. |
docs/luigi-compound-container-api.md
Outdated
```js | ||
myContainer.deferInit = true | ||
``` | ||
TODO: is it preferred to assign true or declare it to indicate it's set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
totally fine to set it to true
docs/luigi-compound-container-api.md
Outdated
``` | ||
|
||
```HTML | ||
<luigi-container viewUrl="/index.html" compoundConfig='{foo: bar}'></luigi-container> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we should provide an example for compould attribute in html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
given the size of it, it seems reasonable to not wanting people to do it this way so I removed it
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
Co-authored-by: Johannes Doberer <[email protected]>
46d34f0
to
115ef0b
Compare
Description
Changes proposed in this pull request:
Related issue(s)
Fixed #3848