Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch to new parameter name #4968

Merged
merged 7 commits into from
Jun 28, 2024
Merged

chore: switch to new parameter name #4968

merged 7 commits into from
Jun 28, 2024

Conversation

o-liver
Copy link
Member

@o-liver o-liver commented Jun 21, 2024 •
edited
Loading

Since warnings-ng plugin version 11 the blameDisabled parameter has been replaced by skipBlames.
To be compatible with Jenkinsfile Runner we put the recordIssues step into a try/catch, so no exception is thrown and the build fails.

Changes

  • Tests
  • Documentation

@o-liver o-liver self-assigned this Jun 21, 2024
@o-liver o-liver requested a review from a team as a code owner June 21, 2024 11:37
@o-liver o-liver requested a review from kaylinche June 21, 2024 11:38
@o-liver
Copy link
Member Author

o-liver commented Jun 21, 2024

/it

@romanisb romanisb mentioned this pull request Jun 21, 2024
Merged
@srinikitha09
Copy link
Contributor

Just out of curiosity, how did we find about this issue? Did we see any warning in the logs of our service?

@o-liver
Copy link
Member Author

o-liver commented Jun 25, 2024

Just out of curiosity, how did we find about this issue? Did we see any warning in the logs of our service?

@romanisb noticed that updating the Jenkinsfile Runner does not handle the update gracefully, i.e. throws an exception and the pipeline stops short 👎

@o-liver
Copy link
Member Author

o-liver commented Jun 28, 2024

/it

o-liver and others added 5 commits June 28, 2024 11:04
@o-liver
chore: switch to new parameter name
171569d 
Since warnings-ng plugin version 11 the blameDisabled parameter
has been replaced by skipBlames.
To be compatible with Jenkinsfile Runner we put the recordIssues step
into a try/catch, so no exception is thrown and the build fails.
@tiloKo @o-liver
Publish TargetVector enhanced retry (#4971)
e27f89c 
* cache Error, increase max polling duration

* Update abapAddonAssemblyKitPublishTargetVector_generated.go
@doldsimo @DanielMieg @o-liver
Adapt clone step to work with customer-managed Repos (BYOG) (#4966)
837c6c7 
* adding byog credentials for clone command

* adding unit tests for clone body

* adding parameters

* adding optional byog parameters

* fixing typo in username

* remove aliases in config yaml

* change yaml config

* logs

* change info log

* change logs

* remove logs

* adding log statements

* remove log statements

* fixing typo in test class

* change repoTest structure

* remove comment

* remove comment

* generate

* adding unit test comments

* adding error handling

* adding isByog check

* fixing unit test

* generate

* Update manageGitRepositoryUtils_test.go

* restructure isByog parameter

* adding empty line for md linter

* adding config.yaml example to docs

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* Update documentation/docs/steps/abapEnvironmentCloneGitRepo.md

Co-authored-by: Daniel Mieg <[email protected]>

* adding release

---------

Co-authored-by: Daniel Mieg <[email protected]>
@vijayanjay @o-liver
Resilience improvement for mend JRE download (#4974)
96a4592 
Signed-off-by: Vijayan T <[email protected]>
@vijayanjay @o-liver
Improving buildDescriptorExcludeList for npm (#4976)
162cdf8 
Signed-off-by: Vijayan T <[email protected]>
@o-liver o-liver requested a review from a team as a code owner June 28, 2024 09:05
@o-liver
Copy link
Member Author

o-liver commented Jun 28, 2024

/it

@srinikitha09 srinikitha09 assigned o-liver and unassigned o-liver Jun 28, 2024
srinikitha09
srinikitha09 reviewed Jun 28, 2024
View reviewed changes
vars/checksPublishResults.groovy Outdated Show resolved Hide resolved
vars/hadolintExecute.groovy Outdated Show resolved Hide resolved
vars/mavenExecuteStaticCodeChecks.groovy Outdated Show resolved Hide resolved
vars/mavenExecuteStaticCodeChecks.groovy Outdated Show resolved Hide resolved
vars/npmExecuteLint.groovy Outdated Show resolved Hide resolved
@o-liver @srinikitha09
docs: improve wording
b5f871b 
Co-authored-by: Srinikitha Kondreddy <[email protected]>
@o-liver
Copy link
Member Author

o-liver commented Jun 28, 2024

/it

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@o-liver o-liver enabled auto-merge (squash) June 28, 2024 11:01
srinikitha09
srinikitha09 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@srinikitha09 srinikitha09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏼

@o-liver o-liver merged commit fe2e4e7 into master Jun 28, 2024
13 of 14 checks passed
@o-liver o-liver deleted the warningsPluginUpdate branch June 28, 2024 11:17
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into kaniko-context-pref…
e1ff1bb 
…ix-fix

* origin/master: (361 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@o-liver @srinikitha09 @maxatsap
chore: switch to new parameter name (SAP#4968)
7c7bf5a 
* chore: switch to new parameter name

Since warnings-ng plugin version 11 the blameDisabled parameter
has been replaced by skipBlames.
To be compatible with Jenkinsfile Runner we put the recordIssues step
into a try/catch, so no exception is thrown and the build fails.

* docs: improve wording

Co-authored-by: Srinikitha Kondreddy <[email protected]>

---------

Co-authored-by: Srinikitha Kondreddy <[email protected]>
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into malwarescan-async-scan
c3e0329 
* origin/master: (421 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch 'origin/master' into whitesource-sbt-con…
12b7a43 
…fig-fix

* origin/master: (460 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@maxatsap
Merge remote-tracking branch origin/whitesource-sbt-config-fix into v…
81aa48d 
…1.371.0-edp

* origin/whitesource-sbt-config-fix: (462 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
maxatsap added a commit to maxatsap/jenkins-library that referenced this pull request Oct 1, 2024
@maxatsap
Merge remote-tracking branch 'origin/whitesource-sbt-config-fix' into…
ecd8d32 
… v1.386.0-edp

* origin/whitesource-sbt-config-fix: (462 commits)
  fix vaultDisableOverwrite handling (SAP#4990)
  (fix) syft, fixing cyclone dx version to sbom version 1.4 for syft (SAP#4991)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4992)
  Update abapAddonAssemblyKitCheck.yaml (SAP#4988)
  Find dist folder from sources (SAP#4984)
  Mend verbose mode improvements (SAP#4982)
  fix(groovy): handle NPE in utils unstash (SAP#4969)
  DetectExecuteScan enhance logging && Adding new parameter (includeDevDependencies) for WS step  (SAP#4958)
  Disable telemetry reporting (SAP#4983)
  Fixed excluded directories with pattern (SAP#4980)
  fix(credentialdiggerScan): get_discoveries and docker image (SAP#4613)
  Cleanup outdated blue green support for cf native build tools (SAP#4965)
  Excluded directory '.pipeline' for detectExecuteScan step (SAP#4955)
  chore: switch to new parameter name (SAP#4968)
  Improving buildDescriptorExcludeList for npm (SAP#4976)
  Resilience improvement for mend JRE download (SAP#4974)
  Adapt clone step to work with customer-managed Repos (BYOG) (SAP#4966)
  Publish TargetVector enhanced retry (SAP#4971)
  errorcause and remove telemetry warnings (SAP#4951)
  Enabled the possibility to avoid aggregation of NPM projects in WhitesourceExecuteScan (SAP#4956)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srinikitha09 srinikitha09 srinikitha09 approved these changes

@marcusholl marcusholl Awaiting requested review from marcusholl

@romanisb romanisb Awaiting requested review from romanisb

@kaylinche kaylinche Awaiting requested review from kaylinche

Assignees

@o-liver o-liver

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@o-liver @srinikitha09 @tiloKo @doldsimo @vijayanjay