Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vault): Facilitate Vault OIDC token #4916

Merged
merged 8 commits into from
May 7, 2024
Merged

Conversation

jliempt
Copy link
Member

@jliempt jliempt commented Apr 26, 2024

Is based on changes in #4901 that have been moved here.

Changes

  • Tests
  • Documentation

@jliempt jliempt requested a review from a team as a code owner April 26, 2024 14:14
pkg/vault/oidc.go Outdated Show resolved Hide resolved
@jliempt
Copy link
Member Author

jliempt commented May 7, 2024

/it-go

@jliempt jliempt changed the title feat(vault): Enable Vault OIDC token retrieval feat(vault): Facilitate Vault OIDC token May 7, 2024
Copy link
Member

@CCFenner CCFenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CCFenner CCFenner enabled auto-merge (squash) May 7, 2024 10:31
@CCFenner
Copy link
Member

CCFenner commented May 7, 2024

/it-go

@jliempt
Copy link
Member Author

jliempt commented May 7, 2024

/it-go

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@CCFenner CCFenner merged commit f5fbb7e into master May 7, 2024
12 checks passed
@CCFenner CCFenner deleted the jliempt/vaultOIDC2 branch May 7, 2024 12:19
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
* add functionality to retrieve Vault OIDC token

* fix tests for now

* update error

Co-authored-by: Christopher Fenner <[email protected]>

* implement commented tests

* run mockery for config pkg

---------

Co-authored-by: jliempt <>
Co-authored-by: Christopher Fenner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants