-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rem cx-server references from infrastructure documentation #4886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is another reference in: https://github.com/SAP/jenkins-library/blob/master/DEVELOPMENT.md?plain=1#L73
Otherwise looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beside the comment already provided by @kaylinche it looks good. That reference should also be removed before merging.
/it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/it |
Quality Gate passedIssues Measures |
* Rem cx-server references from infrastructure documentation * Rem reference to cx server in plugin doc * Rem cx-server reference from abap doc * Rem cx-server reference from gcts cod * Rem cx-server ref from guided tour * Rem unused links * Rem unused refs * remove cx-server from development.md --------- Co-authored-by: Oliver Feldmann <[email protected]> Co-authored-by: tiloKo <[email protected]>
We deprecated the cx-server repo and image last year. These images should not be used anymore. Remaining references in the documentation need to go.
Changes