allow commands in subpackages #4696
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add |
|
Pull request got stale and no further activity happened. It has automatically been closed. Please re-open in case you still consider it relevant. |
|
@anilkeshav27 did you see this? It might be well worth a step to tackle the monolith nature of the Piper library. If I remember correctly, we discussed this in the architecture meeting and everyone considered it problematic but tough to tackle. Maybe this is worth a look as a small step in this direction. |
|
After I opened this PR, I had a DM with @OliverNocon. He seemed interested, but recommended to address this with @CCFenner. I pinged him and didn't hear back since. Maybe I should have pinged him again, what I hereby do now 😆, but actually I don't think it should be required to actively ping people for reviews after opening a PR just to get a review (might be fair if you need it fast). Anyway, as I already said back then: I guess this could be split into multiple PRs, e.g. one that changes the generator and one that actually moves the |
|
|
Thank you for your contribution! This pull request is stale because it has been open 60 days with no activity. In order to keep it open, please remove stale label or add a comment within the next 10 days. If you need a Piper team member to remove the stale label make sure to add |
|
Pull request got stale and no further activity happened. It has automatically been closed. Please re-open in case you still consider it relevant. |
|
similar to #4906 |
The cmd package gets bigger and bigger.
With this change a command can be moved to a sub-package (using the metadata yaml).
This should make the code more navigatable and speed up go compilation when iterating locally i.e. running
go test, do some changes,go test, changes, ... (AFAIK the compilation unit in go is a package and if anything changes in that package, the whole package has to be recompiled).For now I only moved the
cnbBuildcommand to an subpackage. But with this changes it should be rather easy to move further commands (e.g. move allabap...commands into a commonabappackage).