fix(codeqlExecuteScan): moved flag checkIfCompliance #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nkins-library into codeql-sarif-upload-fix
|
/it |
sumeetpatil
reviewed
Jul 11, 2023
|
/it |
sumeetpatil
approved these changes
Jul 11, 2023
|
/it |
|
Kudos, SonarCloud Quality Gate passed!
|
maxatsap
pushed a commit
to maxatsap/jenkins-library
that referenced
this pull request
Jul 23, 2024
* moved checkForCompliance flag, updated description of sarif check params * added generated codeqlExecuteScan * moved appending reports before checking for compliance --------- Co-authored-by: sumeet patil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Moved flag checkIfCompliance to generate audit file for cumulus before compliance checking.
Updated description for sarifCheckMaxRetries and sarifCheckRetryInterval as these params should not only be set if checkIfCompliance is enabled.