feat: remove SAP web analytics reporting (#4773)

* improve vault logging * remove swa calls * Revert "improve vault logging" This reverts commit 8335bbf.
SAP · Jan 15, 2024 · 70b860f · 70b860f
1 parent 86a59eb
commit 70b860f
Show file tree

Hide file tree

Showing 45 changed files with 2 additions and 261 deletions.
diff --git a/src/com/sap/piper/Utils.groovy b/src/com/sap/piper/Utils.groovy
@@ -135,12 +135,7 @@ def generateSha1(input) {
 
 void pushToSWA(Map parameters, Map config) {
     try {
-        parameters.actionName = parameters.get('actionName') ?: 'Piper Library OS'
-        parameters.eventType = parameters.get('eventType') ?: 'library-os'
-        parameters.jobUrlSha1 = generateSha1(env.JOB_URL ?: '')
-        parameters.buildUrlSha1 = generateSha1(env.BUILD_URL ?: '')
-
-        Telemetry.notify(this, config, parameters)
+        echo "SAP web analytics is disabled. Please remove any remaining use of 'pushToSWA' function!"
     } catch (ignore) {
         // some error occured in telemetry reporting. This should not break anything though.
         echo "[${parameters.step}] Telemetry Report failed: ${ignore.getMessage()}"

diff --git a/vars/artifactSetVersion.groovy b/vars/artifactSetVersion.groovy
@@ -153,16 +153,6 @@ void call(Map parameters = [:], Closure body = null) {
         config = configHelper.addIfEmpty('timestamp', getTimestamp(config.timestampTemplate))
             .use()
 
-        new Utils().pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'buildTool',
-            stepParam1: config.buildTool,
-            stepParamKey2: 'artifactType',
-            stepParam2: config.artifactType,
-            stepParamKey3: 'scriptMissing',
-            stepParam3: parameters?.script == null
-        ], config)
-
         def artifactVersioning = ArtifactVersioning.getArtifactVersioning(config.buildTool, script, config)
         def currentVersion = artifactVersioning.getVersion()
 

diff --git a/vars/buildExecute.groovy b/vars/buildExecute.groovy
@@ -74,9 +74,6 @@ void call(Map parameters = [:]) {
             .addIfEmpty('buildTool', script.commonPipelineEnvironment.getBuildTool())
             .use()
 
-        // telemetry reporting
-        utils.pushToSWA([stepParam1: config.buildTool, 'buildTool': config.buildTool], config)
-
         switch(config.buildTool){
             case 'maven':
                 mavenBuild script: script

diff --git a/vars/checkChangeInDevelopment.groovy b/vars/checkChangeInDevelopment.groovy
@@ -111,12 +111,6 @@ void call(parameters = [:]) {
             // for the following parameters we expect a value provided from outside
             .withMandatoryProperty('changeManagement/endpoint')
 
-        new Utils().pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'scriptMissing',
-            stepParam1: parameters?.script == null
-        ], configuration)
-
         def changeId = getChangeDocumentId(script, configuration)
 
         configuration = configHelper.mixin([changeDocumentId: changeId?.trim() ?: null], ['changeDocumentId'] as Set)
@@ -186,4 +180,4 @@ static void addPipelineWarning(Script script, String heading, String message) {
             """
 
     script.createSummary(icon: "warning.gif", text: html)
-}
+}
diff --git a/vars/checksPublishResults.groovy b/vars/checksPublishResults.groovy
@@ -93,12 +93,6 @@ void call(Map parameters = [:]) {
             error "[ERROR] Configuration of the aggregation view is no longer possible. Migrate any thresholds defined here to tool specific quality gates. (piper-lib/${STEP_NAME})"
         }
 
-        new Utils().pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'scriptMissing',
-            stepParam1: parameters?.script == null
-        ], configuration)
-
         // JAVA
         if(configuration.pmd.active) {
           report(pmdParser(createToolOptions(configuration.pmd)), configuration.pmd, configuration.archive)

diff --git a/vars/containerPushToRegistry.groovy b/vars/containerPushToRegistry.groovy
@@ -81,11 +81,6 @@ void call(Map parameters = [:]) {
             config.sourceRegistry = dockerUtils.getRegistryFromUrl(config.sourceRegistryUrl)
         }
 
-        // telemetry reporting
-        new Utils().pushToSWA([
-            step: STEP_NAME
-        ], config)
-
         if (!config.dockerImage)
             config.dockerImage = config.sourceImage
 

diff --git a/vars/debugReportArchive.groovy b/vars/debugReportArchive.groovy
@@ -49,12 +49,6 @@ void call(Map parameters = [:]) {
             .mixin(parameters, PARAMETER_KEYS)
             .use()
 
-        utils.pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'scriptMissing',
-            stepParam1: parameters?.script == null
-        ], configuration)
-
         boolean shareConfidentialInformation = configuration?.get('shareConfidentialInformation') ?: false
 
         Map result = DebugReport.instance.generateReport(script, shareConfidentialInformation)

diff --git a/vars/dockerExecute.groovy b/vars/dockerExecute.groovy
@@ -168,14 +168,6 @@ void call(Map parameters = [:], body) {
 
         SidecarUtils sidecarUtils = new SidecarUtils(script)
 
-        utils.pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'scriptMissing',
-            stepParam1: parameters?.script == null,
-            stepParamKey2: 'kubernetes',
-            stepParam2: isKubernetes()
-        ], config)
-
         if (isKubernetes() && config.dockerImage) {
             List dockerEnvVars = []
             config.dockerEnvVars?.each { key, value ->

diff --git a/vars/dockerExecuteOnKubernetes.groovy b/vars/dockerExecuteOnKubernetes.groovy
@@ -255,12 +255,6 @@ void call(Map parameters = [:], body) {
             .addIfEmpty('uniqueId', UUID.randomUUID().toString())
             .use()
 
-        utils.pushToSWA([
-            step         : STEP_NAME,
-            stepParamKey1: 'scriptMissing',
-            stepParam1   : parameters?.script == null
-        ], config)
-
         if (!config.containerMap && config.dockerImage) {
             config.containerName = 'container-exec'
             config.containerMap = [(config.get('dockerImage')): config.containerName]

diff --git a/vars/dubExecute.groovy b/vars/dubExecute.groovy
@@ -50,12 +50,6 @@ void call(Map parameters = [:], body = null) {
             .mixin(parameters, PARAMETER_KEYS)
             .use()
 
-        new Utils().pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'scriptMissing',
-            stepParam1: parameters?.script == null
-        ], configuration)
-
         if (!fileExists('dub.json') && !fileExists('dub.sdl')) {
             error "[${STEP_NAME}] Neither dub.json nor dub.sdl was found."
         }

diff --git a/vars/gatlingExecuteTests.groovy b/vars/gatlingExecuteTests.groovy
@@ -48,12 +48,6 @@ void call(Map parameters = [:]) {
             .withMandatoryProperty('pomPath')
             .use()
 
-        utils.pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'pomPath',
-            stepParam1: config.pomPath,
-        ], config)
-
         def appUrls = parameters.get('appUrls')
         if (appUrls && !(appUrls instanceof List)) {
             error "The optional parameter 'appUrls' needs to be a List of Maps, where each Map contains the two entries 'url' and 'credentialsId'."

diff --git a/vars/healthExecuteCheck.groovy b/vars/healthExecuteCheck.groovy
@@ -51,8 +51,6 @@ void call(Map parameters = [:]) {
             .withMandatoryProperty('testServerUrl')
             .use()
 
-        new Utils().pushToSWA([step: STEP_NAME], config)
-
         def checkUrl = config.testServerUrl
         if(config.healthEndpoint){
             if(!checkUrl.endsWith('/'))

diff --git a/vars/influxWriteData.groovy b/vars/influxWriteData.groovy
@@ -96,12 +96,6 @@ void call(Map parameters = [:]) {
             .addIfNull('customDataMapTags', InfluxData.getInstance().getTags().findAll({ it.key != 'jenkins_custom_data' }))
             .use()
 
-        new Utils().pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'scriptMissing',
-            stepParam1: parameters?.script == null
-        ], config)
-
         if (!config.artifactVersion)  {
             //this takes care that terminated builds due to milestone-locking do not cause an error
             echo "[${STEP_NAME}] no artifact version available -> exiting writeInflux without writing data"

diff --git a/vars/mailSendNotification.groovy b/vars/mailSendNotification.groovy
@@ -96,8 +96,6 @@ void call(Map parameters = [:]) {
             .mixin(parameters, PARAMETER_KEYS)
             .use()
 
-        new Utils().pushToSWA([step: STEP_NAME], config)
-
         //this takes care that terminated builds due to milestone-locking do not cause an error
         if (script.commonPipelineEnvironment.getBuildResult() == 'ABORTED') return
 

diff --git a/vars/multicloudDeploy.groovy b/vars/multicloudDeploy.groovy
@@ -68,12 +68,6 @@ void call(parameters = [:]) {
 
         Map config = configHelper.use()
 
-        utils.pushToSWA([
-            step         : STEP_NAME,
-            stepParamKey1: 'enableZeroDowntimeDeployment',
-            stepParam1   : config.enableZeroDowntimeDeployment
-        ], config)
-
         def index = 1
         def deployments = [:]
 

diff --git a/vars/neoDeploy.groovy b/vars/neoDeploy.groovy
@@ -207,16 +207,6 @@ void call(parameters = [:]) {
         if(deployMode != DeployMode.MTA && ! extensionFileNames.isEmpty())
             error "Extensions (${extensionFileNames} found for deploy mode ${deployMode}. Extensions are only supported for deploy mode '${DeployMode.MTA}')"
 
-        utils.pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'deployMode',
-            stepParam1: configuration.deployMode == 'mta'?'mta':'war', // ['mta', 'warParams', 'warPropertiesFile']
-            stepParamKey2: 'warAction',
-            stepParam2: configuration.warAction == 'rolling-update'?'blue-green':'standard', // ['deploy', 'deploy-mta', 'rolling-update']
-            stepParamKey3: 'scriptMissing',
-            stepParam3: parameters?.script == null,
-        ], configuration)
-
         if(configuration.neo.credentialType == 'UsernamePassword'){
             withCredentials([usernamePassword(
                 credentialsId: configuration.neo.credentialsId,

diff --git a/vars/npmExecute.groovy b/vars/npmExecute.groovy
@@ -50,12 +50,6 @@ void call(Map parameters = [:], body = null) {
             .mixin(parameters, PARAMETER_KEYS)
             .use()
 
-        new Utils().pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'scriptMissing',
-            stepParam1: parameters?.script == null
-        ], configuration)
-
         try {
             if (!fileExists('package.json')) {
                 error "[${STEP_NAME}] package.json is not found."

diff --git a/vars/pipelineStashFilesAfterBuild.groovy b/vars/pipelineStashFilesAfterBuild.groovy
@@ -47,12 +47,6 @@ void call(Map parameters = [:]) {
             .mixin(parameters, PARAMETER_KEYS)
             .use()
 
-        utils.pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'scriptMissing',
-            stepParam1: parameters?.script == null
-        ], config)
-
         config.stashIncludes.each {stashKey, stashIncludes ->
             def useDefaultExcludes = !config.noDefaultExludes.contains(stashKey)
             utils.stashWithMessage(stashKey, "[${STEP_NAME}] no files detected for stash '${stashKey}': ", stashIncludes, config.stashExcludes[stashKey]?:'', useDefaultExcludes)

diff --git a/vars/pipelineStashFilesBeforeBuild.groovy b/vars/pipelineStashFilesBeforeBuild.groovy
@@ -45,12 +45,6 @@ void call(Map parameters = [:]) {
             .mixin(parameters, PARAMETER_KEYS)
             .use()
 
-        utils.pushToSWA([
-            step: STEP_NAME,
-            stepParamKey1: 'scriptMissing',
-            stepParam1: parameters?.script == null
-        ], config)
-
         config.stashIncludes.each {stashKey, stashIncludes ->
             def useDefaultExcludes = !config.noDefaultExludes.contains(stashKey)
             utils.stashWithMessage(stashKey, "[${STEP_NAME}] no files detected for stash '${stashKey}': ", stashIncludes, config.stashExcludes[stashKey]?:'', useDefaultExcludes)

diff --git a/vars/piperPipelineStageAcceptance.groovy b/vars/piperPipelineStageAcceptance.groovy
@@ -70,10 +70,6 @@ void call(Map parameters = [:]) {
         .use()
 
     piperStageWrapper (script: script, stageName: stageName) {
-
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         // Prefer the newer multicloudDeploy step if it is configured as it is more capable
         if (config.multicloudDeploy) {
             durationMeasure(script: script, measurementName: 'deploy_test_multicloud_duration') {

diff --git a/vars/piperPipelineStageAdditionalUnitTests.groovy b/vars/piperPipelineStageAdditionalUnitTests.groovy
@@ -45,10 +45,6 @@ void call(Map parameters = [:]) {
         .use()
 
     piperStageWrapper (script: script, stageName: stageName) {
-
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         if (config.batsExecuteTests) {
             durationMeasure(script: script, measurementName: 'bats_duration') {
                 batsExecuteTests script: script

diff --git a/vars/piperPipelineStageBuild.groovy b/vars/piperPipelineStageBuild.groovy
@@ -57,10 +57,6 @@ void call(Map parameters = [:]) {
         .use()
 
     piperStageWrapper (script: script, stageName: stageName) {
-
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         durationMeasure(script: script, measurementName: 'build_duration') {
 
             buildExecute script: script

diff --git a/vars/piperPipelineStageCompliance.groovy b/vars/piperPipelineStageCompliance.groovy
@@ -38,10 +38,6 @@ void call(Map parameters = [:]) {
         .use()
 
     piperStageWrapper (script: script, stageName: stageName) {
-
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         if (config.sonarExecuteScan) {
             durationMeasure(script: script, measurementName: 'sonar_duration') {
                 sonarExecuteScan script: script

diff --git a/vars/piperPipelineStageInit.groovy b/vars/piperPipelineStageInit.groovy
@@ -203,9 +203,6 @@ void call(Map parameters = [:]) {
             echo "piper-lib-os  configuration: ${script.commonPipelineEnvironment.configuration}"
         }
 
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         piperInitRunStageConfiguration script: script, stageConfigResource: config.stageConfigResource
 
         // CHANGE_ID is set only for pull requests

diff --git a/vars/piperPipelineStageIntegration.groovy b/vars/piperPipelineStageIntegration.groovy
@@ -42,10 +42,6 @@ void call(Map parameters = [:]) {
         .use()
 
     piperStageWrapper (script: script, stageName: stageName) {
-
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         boolean publishResults = false
         try {
             writeTemporaryCredentials(script: script) {

diff --git a/vars/piperPipelineStageMavenStaticCodeChecks.groovy b/vars/piperPipelineStageMavenStaticCodeChecks.groovy
@@ -37,10 +37,6 @@ void call(Map parameters = [:]) {
         .use()
 
     piperStageWrapper(stageName: stageName, script: script) {
-
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         if (config.mavenExecuteStaticCodeChecks) {
             mavenExecuteStaticCodeChecks(script: script)
         }

diff --git a/vars/piperPipelineStagePRVoting.groovy b/vars/piperPipelineStagePRVoting.groovy
@@ -99,10 +99,6 @@ void call(Map parameters = [:]) {
         .use()
 
     piperStageWrapper (script: script, stageName: stageName) {
-
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         durationMeasure(script: script, measurementName: 'voter_duration') {
 
             //prevent push to registry in case of docker/kaniko

diff --git a/vars/piperPipelineStagePerformance.groovy b/vars/piperPipelineStagePerformance.groovy
@@ -41,10 +41,6 @@ void call(Map parameters = [:]) {
         .use()
 
     piperStageWrapper (script: script, stageName: stageName) {
-
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         if (config.multicloudDeploy) {
             durationMeasure(script: script, measurementName: 'deploy_performance_multicloud_duration') {
                 multicloudDeploy(script: script, stage: stageName)

diff --git a/vars/piperPipelineStagePost.groovy b/vars/piperPipelineStagePost.groovy
@@ -46,9 +46,6 @@ void call(Map parameters = [:]) {
             vaultRotateSecretId script: script
         }
 
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         influxWriteData script: script
         if(env.BRANCH_NAME == parameters.script.commonPipelineEnvironment.getStepConfiguration('', '').productiveBranch) {
             if(parameters.script.commonPipelineEnvironment.configuration.runStep?.get('Post Actions')?.slackSendNotification) {

diff --git a/vars/piperPipelineStagePromote.groovy b/vars/piperPipelineStagePromote.groovy
@@ -41,10 +41,6 @@ void call(Map parameters = [:]) {
         .use()
 
     piperStageWrapper (script: script, stageName: stageName) {
-
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         durationMeasure(script: script, measurementName: 'promote_duration') {
             if (config.containerPushToRegistry) {
                 containerPushToRegistry script: script

diff --git a/vars/piperPipelineStageRelease.groovy b/vars/piperPipelineStageRelease.groovy
@@ -62,10 +62,6 @@ void call(Map parameters = [:]) {
         .use()
 
     piperStageWrapper (script: script, stageName: stageName) {
-
-        // telemetry reporting
-        utils.pushToSWA([step: STEP_NAME], config)
-
         // Prefer the newer multicloudDeploy step if it is configured as it is more capable
         if (config.multicloudDeploy) {
             durationMeasure(script: script, measurementName: 'deploy_release_multicloud_duration') {

diff --git a/vars/piperPipelineStageSecurity.groovy b/vars/piperPipelineStageSecurity.groovy
@@ -104,9 +104,6 @@ void call(Map parameters = [:]) {
         }
 
         if (securityScanMap.size() > 0) {
-            // telemetry reporting
-            utils.pushToSWA([step: STEP_NAME], config)
-
             parallel securityScanMap.plus([failFast: false])
         }
     }