chore: remove old add new node versions #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove old node 16 images and add new node 22, which is also the latest now.
|
FYI |
o-liver
commented
Oct 10, 2024
| @@ -43,7 +43,7 @@ jobs: | |||
| echo "${{ secrets.CR_PAT }}" | docker login https://ghcr.io -u ${{ secrets.CR_USER }} --password-stdin | |||
| docker push ppiper/node-browsers:${{ matrix.base-image-tag }} | |||
| docker push ghcr.io/sap/ppiper-node-browsers:${{ matrix.base-image-tag }} | |||
| if [ "${{ matrix.base-image-tag }}" == 20-bookworm ]; then | |||
| if [ "${{ matrix.base-image-tag }}" == 22-bookworm ]; then | |||
There was a problem hiding this comment.
@kaylinche Question: should we already tag node 22 as latest, or wait for the official switch as Active LTS before tagging it latest?
There was a problem hiding this comment.
From my side it is fine to tag 22 already as latest.
kaylinche
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old node 16 images and add new node 22, which is also the latest now.